Add toolchain cfg for testing msrv#1515
Merged
djkoloski merged 1 commit intogoogle:mainfrom Jul 16, 2024
Merged
Conversation
6 tasks
3c35ad6 to
ab6f32a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1515 +/- ##
=======================================
Coverage 87.69% 87.70%
=======================================
Files 15 15
Lines 5560 5563 +3
=======================================
+ Hits 4876 4879 +3
Misses 684 684 ☔ View full report in Codecov by Sentry. |
joshlf
requested changes
Jul 12, 2024
joshlf
reviewed
Jul 12, 2024
0bb8ac9 to
523aee2
Compare
joshlf
approved these changes
Jul 13, 2024
Member
joshlf
left a comment
There was a problem hiding this comment.
Can you squash this into one commit?
523aee2 to
6c7b8be
Compare
djkoloski
added a commit
that referenced
this pull request
Jul 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also renames
__INTERNAL_USE_ONLY_NIGHTLY_FEATURES_IN_TESTSto__ZEROCOPY_INTERNAL_USE_ONLY_NIGHTLY_FEATURES_IN_TESTSfor consistency.