[derive] Clean up AsBytes support on repr(packed)#128
Merged
Conversation
Unify our handling of `repr(packed)` and `repr(transparent)` when deriving `AsBytes`, and bring error messages up to date with the fact that we support both of these reprs on generic structs. Closes #127
8abf5fe to
244b9fe
Compare
Member
Author
|
@djkoloski can you take a look at this when you get a chance? |
djkoloski
approved these changes
Nov 7, 2022
joshlf
added a commit
that referenced
this pull request
Aug 3, 2023
Unify our handling of `repr(packed)` and `repr(transparent)` when deriving `AsBytes`, and bring error messages up to date with the fact that we support both of these reprs on generic structs. Closes #127
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unify our handling of
repr(packed)andrepr(transparent)when derivingAsBytes, and bring error messages up to date with the fact that we support both of these reprs on generic structs.Closes #127