Conversation
0cd1ea0 to
90678f8
Compare
joshlf
left a comment
There was a problem hiding this comment.
One more tiny nit, but otherwise lgtm!
90678f8 to
469c916
Compare
dbcb304 to
ff9ca67
Compare
|
I wanted to incorporate some additional |
Yeah, I miss gerrit all the time 😞 GitHub's UI is great, but the fact that you can't stack PRs is a travesty. I haven't been doing dev on GH long enough to know the real tricks, but so far my approach has been to just carve off one commit at a time to put through the PR cycle. It's a lot easier for me since I'm self-approving a lot of the more minor changes. I feel like where stacked PRs is a huge deal is when you want to have multiple reviews ongoing at a time. |
|
Oh but to respond to your comment about this PR: I saw, and those changes look great! I'm happy to just keep them in this PR and we can figure out a better workflow later if it keeps being a problem. |
eb307a5 to
30acdfe
Compare
Also consolidates some utility types and macros.
|
Got some friction with CI, #69 would help improve the contribution experience. |
Also consolidate some utility types and macros. Closes #9
Fixes #9. Depends on #119 because the generated generic bounds cannot be used in a constant context.