modules/zstd: add BlockDecoder #1214
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51e9672 to
141e325
Compare
9c99c3d to
611162a
Compare
be431b3 to
5291294
Compare
b0f7013 to
82d430e
Compare
8ef2e9c to
3b1da80
Compare
3b1da80 to
07ecf8f
Compare
This commit adds a DSLX Buffer library that provides the Buffer struct, and helper functions that can be used to operate on it. The Buffer is meant to be a storage for data coming from the channel. It acts like a FIFO, allowing data of any length to be put in or popped out of it. Provided DSLX tests verify the correct behaviour of the library. Internal-tag: [#50221] Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
This commit adds a simple test that shows, how one can use the Buffer struct inside a Proc. Internal-tag: [#50221] Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
This commit adds the library with functions for parsing a magic number and tests that verify its correctness. Internal-tag: [#50221] Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
This commit adds the library with functions for parsing a frame header. The provided tests verify the correcness of the library. Internal-tag: [#49967] Co-authored-by: Roman Dobrodii <rdobrodii@antmicro.com> Co-authored-by: Pawel Czarnecki <pczarnecki@antmicro.com> Signed-off-by: Robert Winkler <rwinkler@antmicro.com> Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Internal-tag: [#53329] Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Required for expected_status inference in C++ tests for ZSTD decoder components Internal-tag: [#53465] Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Internal-tag: [#50967] Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
This commit adds a binary that calls decoding to generate data and loads it into a vector of bytes. Internal-tag: [#50967] Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Internal-tag: [#50967] Co-authored-by: Pawel Czarnecki <pczarnecki@antmicro.com> Signed-off-by: Robert Winkler <rwinkler@antmicro.com> Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Internal-tag: [#51343] Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Internal-tag: [#51343] Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Internal-tag: [#53329] Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Adds RleBlockDecoder responsible for decoding Blocks of RLE_Block Block_Type as specified in RFC 8878, paragraph 3.1.1.2.2. https://datatracker.ietf.org/doc/html/rfc8878#section-3.1.1.2.2 RleBlockDecoder communicates through BlockDataPacket channels. It reuses existing RunLengthDecoder block which is interfaced through two seprate procs: * RleDataPacker * BatchPacker Which are responsible for converting input data into format accepted by RLE decoder and for gathering RLE decoder output symbols into batches which are then send out through BlockDataPacket. Internal-tag: [#51473] Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Internal-tag: [#53329] Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Internal-tag: [#53329] Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Internal-tag: [#51343] Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
This commit adds DecoderMux Proc, which collects data from specialized Raw, RLE, and Compressed Block decoders and re-sends them in the correct order. Internal-tag: [#51343] Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Internal-tag: [#53329] Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
This DSLX proc responsibility is to dispatch encoded blocks to a correct decoder: RAW, RLE, COMPRESSED. It tracks and assigns block IDs. The ID counter is reset on the frame's last block on the last data packet. Internal-tag: [#51736] Co-authored-by: Robert Winkler <rwinkler@antmicro.com> Signed-off-by: Maciej Dudek <mdudek@antmicro.com>
Internal-tag: [#53329] Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Internal-tag: [#53329] Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
This adds a decoder of block data. It decodes block header and demuxes remaining input data into one of specific block decoders depending on the type of the parsed block. Then it muxes outputs from those decoders into single output channel. Internal-tag: [#51873] Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Internal-tag: [#53329] Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Internal-tag: [#53329] Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
07ecf8f to
caf2b7c
Compare
lpawelcz
pushed a commit
to antmicro/xls
that referenced
this pull request
Feb 21, 2024
google#1214 modules/zstd: Add block header parsing library Internal-tag: [#51343] Signed-off-by: Robert Winkler <rwinkler@antmicro.com> modules/zstd: Add SequenceExecutorPacket to common definitions Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com> modules/zstd: Add block data muxer library This commit adds DecoderMux Proc, which collects data from specialized Raw, RLE, and Compressed Block decoders and re-sends them in the correct order. Internal-tag: [#51343] Signed-off-by: Robert Winkler <rwinkler@antmicro.com> modules/zstd/dec_mux: Add benchmarking rules Internal-tag: [#53329] Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com> modules/zstd: Add block demuxer library This DSLX proc responsibility is to dispatch encoded blocks to a correct decoder: RAW, RLE, COMPRESSED. It tracks and assigns block IDs. The ID counter is reset on the frame's last block on the last data packet. Internal-tag: [#51736] Co-authored-by: Robert Winkler <rwinkler@antmicro.com> Signed-off-by: Maciej Dudek <mdudek@antmicro.com> modules/zstd/dec_demux: Specify fifo depths for internal channels Internal-tag: [#53329] Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com> modules/zstd/dec_demux: Add benchmarking rules Internal-tag: [#53329] Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com> modules/zstd: Add block decoder module This adds a decoder of block data. It decodes block header and demuxes remaining input data into one of specific block decoders depending on the type of the parsed block. Then it muxes outputs from those decoders into single output channel. Internal-tag: [#51873] Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com> modules/zstd/block_dec: Specify fifo depths for internal channels Internal-tag: [#53329] Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com> modules/zstd/block_dec: Add benchmarking rules Internal-tag: [#53329] Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
lpawelcz
pushed a commit
to antmicro/xls
that referenced
this pull request
Mar 7, 2024
google#1214 modules/zstd: Add block header parsing library Internal-tag: [#51343] Signed-off-by: Robert Winkler <rwinkler@antmicro.com> modules/zstd: Add SequenceExecutorPacket to common definitions Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com> modules/zstd: Add block data muxer library This commit adds DecoderMux Proc, which collects data from specialized Raw, RLE, and Compressed Block decoders and re-sends them in the correct order. Internal-tag: [#51343] Signed-off-by: Robert Winkler <rwinkler@antmicro.com> modules/zstd/dec_mux: Add benchmarking rules Internal-tag: [#53329] Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com> modules/zstd: Add block demuxer library This DSLX proc responsibility is to dispatch encoded blocks to a correct decoder: RAW, RLE, COMPRESSED. It tracks and assigns block IDs. The ID counter is reset on the frame's last block on the last data packet. Internal-tag: [#51736] Co-authored-by: Robert Winkler <rwinkler@antmicro.com> Signed-off-by: Maciej Dudek <mdudek@antmicro.com> modules/zstd/dec_demux: Specify fifo depths for internal channels Internal-tag: [#53329] Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com> modules/zstd/dec_demux: Add benchmarking rules Internal-tag: [#53329] Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com> modules/zstd: Add block decoder module This adds a decoder of block data. It decodes block header and demuxes remaining input data into one of specific block decoders depending on the type of the parsed block. Then it muxes outputs from those decoders into single output channel. Internal-tag: [#51873] Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com> modules/zstd/block_dec: Specify fifo depths for internal channels Internal-tag: [#53329] Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com> modules/zstd/block_dec: Add benchmarking rules Internal-tag: [#53329] Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Member
|
should we close this and focus on reviewing #1315 ? |
Contributor
Author
|
Closing. The review will take place in #1315 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
DecoderMuxProc, which collects data from specialized Raw, RLE, and Compressed Block decoders and re-sends them in the correct orderDecoderDemuxProc, which is responsible for parsing Block Header and sending the obtained data to the Raw, RLE or Compressed Block decodersBlockDecoderProc, which aggregates the created Decoders together with Muxer and Demuxer. The block is responsible for decoding complete ZSTD Blocks. Currently, it supports RAW and RLE Block types.NOTE: this is based on #1213 , please ignore commits from that branch when reviewing.
This is part of #1211
CC @proppy