Improve RemoveFunctionDuplicates to handle parametric functions #1204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll by multiple sources This commit adds a test that checks DSLX to IR conversion when a parametric function is called by both non parametric function and process. The test uses IR conversion GetOrder function, as it’s a case when IR "top" value is undefined. This occurs when jitting or running ir_conversion_main without specifying "top" argument. In this test `main.next` should be a top level function, with `call_parametric_from_no_parametric` and `parametric_fn` as callees. Signed-off-by: Maciej Dudek <mdudek@antmicro.com>
…rameters are equal Signed-off-by: Maciej Dudek <mdudek@antmicro.com>
proppy
reviewed
Nov 30, 2023
proppy
reviewed
Nov 30, 2023
proppy
reviewed
Nov 30, 2023
Signed-off-by: Maciej Dudek <mdudek@antmicro.com>
Contributor
Author
|
@proppy I've updated this PR with suggested improvements |
Contributor
Author
Member
|
I don't see change to the interpreter, is that expected? |
proppy
reviewed
Jan 18, 2024
Signed-off-by: Maciej Dudek <mdudek@antmicro.com>
Contributor
Author
|
I believe, this PR fixes issue with interpreter. |
lpawelcz
pushed a commit
to antmicro/xls
that referenced
this pull request
Feb 21, 2024
google#1204 xls/dslx/ir_conversion: Remove parametric functions when names and parameters are equal Internal-tag: [#52186] Signed-off-by: Maciej Dudek <mdudek@antmicro.com> xls/dslx/ir_conversion: Add test with implicit parametric function call by multiple sources This commit adds a test that checks DSLX to IR conversion when a parametric function is called by both non parametric function and process. The test uses IR conversion GetOrder function, as it’s a case when IR "top" value is undefined. This occurs when jitting or running ir_conversion_main without specifying "top" argument. In this test `main.next` should be a top level function, with `call_parametric_from_no_parametric` and `parametric_fn` as callees. Internal-tag: [#52186] Signed-off-by: Maciej Dudek <mdudek@antmicro.com> review: Fix names Internal-tag: [#52186] Signed-off-by: Maciej Dudek <mdudek@antmicro.com>
Contributor
Author
|
Closing, no longer applicable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #1202 @proppy