Stop including stderr in simulator output#41
Merged
albertdai merged 1 commit intogoogle:masterfrom Feb 3, 2022
Merged
Conversation
On M1 macs running anything with xcrun prints a bunch of these warnings to stderr (FB9089778): ``` objc[35011]: Class AMSupportURLConnectionDelegate is implemented in both /usr/lib/libauthinstall.dylib (0x1ffc8ab90) and /Library/Apple/System/Library/PrivateFrameworks/MobileDevice.framework/Versions/A/MobileDevice (0x1044502c8). One of the two will be used. Which one is undefined. ``` So capturing this output, and then using it as json, is invalid on M1 machines when this happens. None of the consumers of this function check the output for any error strings, so this change should only improve the other use cases.
09f733a to
a171066
Compare
jpsim
approved these changes
Jan 27, 2022
Contributor
Author
|
@albertdai can you review? |
albertdai
approved these changes
Feb 3, 2022
Contributor
Author
|
thanks! |
keith
added a commit
to bazelbuild/rules_apple
that referenced
this pull request
Feb 3, 2022
This includes google/xctestrunner#41
keith
added a commit
to bazelbuild/rules_apple
that referenced
this pull request
Feb 3, 2022
This includes google/xctestrunner#41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On M1 macs running anything with xcrun prints a bunch of these warnings
to stderr (FB9089778):
So capturing this output, and then using it as json, is invalid on M1
machines when this happens. None of the consumers of this function check
the output for any error strings, so this change should only improve the
other use cases.