Add a default image bitmap and an error image bitmap.#227
Merged
jpd236 merged 2 commits intogoogle:masterfrom Oct 11, 2018
Merged
Add a default image bitmap and an error image bitmap.#227jpd236 merged 2 commits intogoogle:masterfrom
jpd236 merged 2 commits intogoogle:masterfrom
Conversation
This lets users choose local bitmaps in addition to local resource IDs.
aaijazi
commented
Oct 11, 2018
| List<Header> allResponseHeaders) { | ||
| this.key = key; | ||
| this.etag = ("".equals(etag)) ? null : etag; | ||
| this.etag = "".equals(etag) ? null : etag; |
Contributor
Author
There was a problem hiding this comment.
This ended up being necessary to build and pass tests locally
Collaborator
There was a problem hiding this comment.
Sorry about that - forked off #229 to keep the commits separate. Evidently our dependency on ErrorProne is not pinned to a specific version. I tried to pin it but it'd require migrating to a newer version of the plugin which appears to be more involved.
jpd236
added a commit
to jpd236/volley
that referenced
this pull request
Oct 11, 2018
1.1 appears stable and a new API will be added shortly in google#227, with more likely to follow in the future. In an emergency, we could fork off a separate branch to continue 1.1 branch releases.
jpd236
approved these changes
Oct 11, 2018
Collaborator
jpd236
left a comment
There was a problem hiding this comment.
Seems reasonable enough. Will merge shortly after bumping the SNAPSHOT version to 1.2.0 since this added a new API. I've merged a separate PR for the build fix to keep the commit simple.
jpd236
added a commit
that referenced
this pull request
Oct 11, 2018
1.1 appears stable and a new API will be added shortly in #227, with more likely to follow in the future. In an emergency, we could fork off a separate branch to continue 1.1 branch releases.
This was referenced Mar 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets users choose local bitmaps in addition to local resource IDs.