Fix race in NewUUID()#64
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
pborman
left a comment
There was a problem hiding this comment.
Thank you for pointing this out. The expectation was the nodeID would only ever be set once as the standard implies it is a fixed value per machine. But you are right, there is a race condition. See my comment below about just moving some code around to get the same effect.
* Fixed race in NewUUID() * Remove unnecessary variable
Fixes race in NewUUID() (non-synchronized access to nodeID)