Skip to content

Change failure message of StringSubject.matches and add test cases#830

Closed
junyan59 wants to merge 1 commit into
google:masterfrom
junyan59:stringMatches
Closed

Change failure message of StringSubject.matches and add test cases#830
junyan59 wants to merge 1 commit into
google:masterfrom
junyan59:stringMatches

Conversation

@junyan59

@junyan59 junyan59 commented Mar 1, 2021

Copy link
Copy Markdown
Contributor

Add an additional message to suggest using containsMatch, if matches(x) fails but containsMatch(x) would have passed. Add corresponding test cases.
issue link: #791

@google-cla

google-cla Bot commented Mar 1, 2021

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@junyan59

junyan59 commented Mar 1, 2021

Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

@google-cla

google-cla Bot commented Mar 1, 2021

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

Add an additional message to suggest using containsMatch, if matches(x) fails but containsMatch(x) would have passed. Add corresponding test cases.
@google-cla google-cla Bot added cla: yes and removed cla: no labels Mar 1, 2021
@kluever kluever added P3 not scheduled type=enhancement Make an existing feature better labels Mar 2, 2021

@cpovirk cpovirk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I no longer remember how I failed to review this, but I very much failed to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes P3 not scheduled type=enhancement Make an existing feature better

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants