Change failure message of StringSubject.matches and add test cases#830
Change failure message of StringSubject.matches and add test cases#830junyan59 wants to merge 1 commit into
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Add an additional message to suggest using containsMatch, if matches(x) fails but containsMatch(x) would have passed. Add corresponding test cases.
cpovirk
left a comment
There was a problem hiding this comment.
I'm sorry, I no longer remember how I failed to review this, but I very much failed to do so.
Add an additional message to suggest using containsMatch, if matches(x) fails but containsMatch(x) would have passed. Add corresponding test cases.
issue link: #791