Merged
Conversation
Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
AlCutter
reviewed
Aug 15, 2024
Member
|
Hi @fghanmi - thanks for the PR, I've dropped a few comments on for you. |
Contributor
Author
Member
|
/gcbrun |
AlCutter
approved these changes
Aug 16, 2024
Member
|
Thanks again @fghanmi! |
fghanmi
added a commit
to securesign/trillian
that referenced
this pull request
Aug 17, 2024
Adds TLS support for MySQL connections in the Trillian server/signer. Key changes include: - Added new flags: + mysql_tls_ca: Path to the CA certificate file for the MySQL TLS connection. + mysql_server_name: Name of the MySQL server to be used as the Server Name in the TLS configuration. - Added a new function registerTLSConfig() to handle the registration of the custom TLS configuration. If no TLS configuration is provided, the connection defaults to non-TLS, ensuring backward compatibility. Issue: google#3592
fghanmi
added a commit
to securesign/trillian
that referenced
this pull request
Aug 17, 2024
Adds TLS support for MySQL connections in the Trillian server/signer. Key changes include: - Added new flags: + mysql_tls_ca: Path to the CA certificate file for the MySQL TLS connection. + mysql_server_name: Name of the MySQL server to be used as the Server Name in the TLS configuration. - Added a new function registerTLSConfig() to handle the registration of the custom TLS configuration. If no TLS configuration is provided, the connection defaults to non-TLS, ensuring backward compatibility. Issue: google#3592
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds TLS support for MySQL connections in the Trillian server/signer. The key changes include:
Added new flags:
mysql_tls_ca: Path to the CA certificate file for the MySQL TLS connection.mysql_server_name: Name of the MySQL server to be used as the Server Name in the TLS configuration.TLS Configuration Registration:
registerTLSConfig()to handle the registration of the custom TLS configuration.If no TLS configuration is provided, the connection defaults to non-TLS, ensuring backward compatibility.
Issue: #3592
Checklist