Fix log server not exiting properly on SIGINT#2805
Merged
AlCutter merged 2 commits intogoogle:masterfrom Sep 6, 2022
Merged
Conversation
Make the tree garbage collection coroutine exit immediately when the context is cancelled.
Contributor
|
/gcbrun |
AlCutter
requested changes
Sep 5, 2022
Member
|
/gcbrun |
AlCutter
approved these changes
Sep 6, 2022
Member
|
Many thanks for the fix! |
sigsum-bot
pushed a commit
to sigsum/log-go
that referenced
this pull request
Sep 9, 2022
Repeated kill is a workaround that can most likely be reverted once google/trillian#2805 makes into into a trillian release. Uses SIGTERM rather than SIGINT, because (i) SIGTERM (the default kill signal) seems more appropriate for scripted usage, while SIGINT is for interactive usage, e.g., pressing Control-C in the terminal, and (ii) SIGINT didn't work in my local tests.
sigsum-bot
pushed a commit
to sigsum/log-go
that referenced
this pull request
Sep 9, 2022
Repeated kill is a workaround that can most likely be reverted once google/trillian#2805 makes into into a trillian release. Uses SIGTERM rather than SIGINT, because (i) SIGTERM (the default kill signal) seems more appropriate for scripted usage, while SIGINT is for interactive usage, e.g., pressing Control-C in the terminal, and (ii) SIGINT didn't work in my local tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the tree garbage collection coroutine exit immediately when the context is cancelled.
This fixes an issue that appeared in 1.4.1: after receiving SIGINT
trillian_log_serverstarts shutting down but seems to get stuck and needs to be killed.Checklist