Merged
Conversation
This partly-reverts commit 4023e5a ("Use sqlite3 as the default driver for unit tests (google#886)"), removing SQLite as a storage option. In practice, having a default DB that doesn't support much of the Trillian functionality (e.g. none of the map tests, none of the integration tests) has inconvenienced core developers. However, to allow the core `git clone <repo> ; go test ./...` scenario to still work without setup dependencies, all DB-using tests explicitly check for MySQL availability and are skipped if MySQL is not present.
Martin2112
approved these changes
Mar 21, 2018
Contributor
Martin2112
left a comment
There was a problem hiding this comment.
Looks ok if travis happy.
Codecov Report
@@ Coverage Diff @@
## master #1064 +/- ##
==========================================
- Coverage 62.32% 62.01% -0.32%
==========================================
Files 103 104 +1
Lines 8513 8563 +50
==========================================
+ Hits 5306 5310 +4
- Misses 2667 2711 +44
- Partials 540 542 +2
Continue to review full report at Codecov.
|
Contributor
|
This might even speed up compile times |
Contributor
|
It should speed things up in general by not having to rerun the flaky
builds.
…On 21 March 2018 at 15:40, Gary Belvin ***@***.***> wrote:
This might even speed up compile times
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1064 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AMv2T8qChdWbLPAdl1g8cC8UK73XkBmeks5tgnRdgaJpZM4S0Rhv>
.
|
Contributor
Author
|
I've added an extra commit with a single reminder test failure -- wdyt? |
Contributor
|
This could be worth having. Might need something similar for CloudSpanner tests when they exist. Mentioning no names etc .... |
daviddrysdale
added a commit
to daviddrysdale/certificate-transparency-go
that referenced
this pull request
Mar 23, 2018
daviddrysdale
added a commit
to google/certificate-transparency-go
that referenced
this pull request
Mar 23, 2018
gdbelvin
added a commit
to gdbelvin/trillian
that referenced
this pull request
Mar 26, 2018
* master: storage/testdb: drop now-unused entrypoints (google#1067) Drop use of SQLite (google#1064) Implement AddSequencedLeaves in MySQL storage (google#1036)
gdbelvin
added a commit
to gdbelvin/keytransparency
that referenced
this pull request
Jul 24, 2018
TRILLIAN_MYSQL_DRIVER was removed in google/trillian#1064
gdbelvin
added a commit
to google/keytransparency
that referenced
this pull request
Jul 25, 2018
TRILLIAN_MYSQL_DRIVER was removed in google/trillian#1064
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This partly-reverts commit 4023e5a ("Use sqlite3 as the default
driver for unit tests (#886)"), removing SQLite as a storage option.
In practice, having a default DB that doesn't support much of the
Trillian functionality (e.g. none of the map tests, none of the
integration tests) has inconvenienced core developers.
However, to allow the core
git clone <repo> ; go test ./...scenario to still work without setup dependencies, all DB-using tests
explicitly check for MySQL availability and are skipped if MySQL
is not present.