Merged
Conversation
felixarntz
previously approved these changes
Apr 12, 2021
Contributor
felixarntz
left a comment
There was a problem hiding this comment.
Excellent! Just one comment, but nothing blocking.
| className="googlesitekit-chart-v2__inner" | ||
| chartEvents={ combinedChartEvents } | ||
| chartType={ chartType } | ||
| chartVersion={ 49 } |
Contributor
There was a problem hiding this comment.
Nit-pick, but shouldn't this be a string? Not a big deal, but it is a string in the regular JS snippet that we use in PHP, and also typically a string in the React wrapper codebase: https://github.com/rakannimer/react-google-charts/blob/master/src/types.ts#L257
|
Size Change: +106 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
danielgent
pushed a commit
that referenced
this pull request
Apr 22, 2021
danielgent
pushed a commit
that referenced
this pull request
May 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue #3132
Relevant technical choices
Checklist