Add BUILD.gn rules.#485
Merged
antiagainst merged 2 commits intogoogle:masterfrom Sep 26, 2018
dj2:gn_build
Merged
Conversation
This CL adds the necessary build configuration to allow building shaderc within a Chromium checkout.
Contributor
Author
|
@Kangz to verify by BUILD.gn is right-ish. I was able to successfully do a build of libshaderc from within the Chromium tree with this and the glslang BUILD.gn file. |
Kangz
reviewed
Sep 24, 2018
BUILD.gn
Outdated
| } | ||
| } | ||
|
|
||
| shared_library("libshaderc") { |
Collaborator
There was a problem hiding this comment.
I think that for Chrome we would like to have a dual source_set and shared_library model. See libdawn_native here: https://dawn.googlesource.com/dawn/+/master/BUILD.gn#313
This would help put shaderc in a component in Chrome. It would require splitting shaderc_public in two.
Collaborator
|
Still LGTM! |
Contributor
Author
|
@antiagainst ping, are you the right person to review this? |
antiagainst
approved these changes
Sep 26, 2018
stenzek
added a commit
to stenzek/shaderc
that referenced
this pull request
Apr 6, 2025
…7798 0e71067798 Fix json capabilities for RayTracingOpacityMicromapEXT (google#498) eceb46dad7 fixes for SPV_INTEL_arbitrary_precision_floating_point (google#495) 0fcd749320 Add grammar entries for SPV_INTEL_task_sequence (google#494) 06633cfeec Add headers for SPV_INTEL_tensor_float32_conversion extension (google#501) d5ee9ed2bb Add SPV_KHR_bfloat16 (google#502) ddd2c099be Update Slang tool entry. (google#496) bf08186d8b ClspvReflection non-sematic: Add WorkgroupVariableSize (google#493) 4793aeec29 remove extra arbitrary precision fixed point instructions operands (google#491) 54a521dd13 Register tool ID 47 for a new ARM SPIR-V generator. (google#486) 6be51b8f7d updates AtomicStorageOps to depend on the AtomicStorage capability (google#479) 09913f088a Remove extra space causing rendering issue (google#485) git-subtree-dir: third_party/spirv-headers git-subtree-split: 0e710677989b4326ac974fd80c5308191ed80965
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CL adds the necessary build configuration to allow building
shaderc within a Chromium checkout.