Skip to content

Glslang generator version 5#440

Merged
dneto0 merged 1 commit intogoogle:masterfrom
dneto0:glslang-generator-5
Mar 7, 2018
Merged

Glslang generator version 5#440
dneto0 merged 1 commit intogoogle:masterfrom
dneto0:glslang-generator-5

Conversation

@dneto0
Copy link
Copy Markdown
Collaborator

@dneto0 dneto0 commented Mar 6, 2018

Make OpArrayLength result type be an integer with signedness of 0.

@dneto0
Glslang generator version 5
0d23433 
Make OpArrayLength result type be an integer with signedness of 0.
@dneto0
Copy link
Copy Markdown
Collaborator Author

dneto0 commented Mar 6, 2018

This is required for refreshing google/glslang from upstream.
Reacts to Glslang version bump from 3 days ago:
KhronosGroup/glslang@0216f24

antiagainst
antiagainst approved these changes Mar 7, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@antiagainst antiagainst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+2. LGTM.

But I'm wondering whether we should just drop testing the generator number, or use regex to make it more resilient to bumps. Does it harm anything if we drop testing the SPIR-V header completely?

@dneto0
Copy link
Copy Markdown
Collaborator Author

dneto0 commented Mar 7, 2018

But I'm wondering whether we should just drop testing the generator number, or use regex to make it more resilient to bumps. Does it harm anything if we drop testing the SPIR-V header completely?

Entirely fair. The generator bump didn't happen for 2 years, then we've had a flurry of them.
Until now I've wanted to check the header in detail out of an abundance of caution.

@dneto0 dneto0 merged commit 0d23433 into google:master Mar 7, 2018
stenzek added a commit to stenzek/shaderc that referenced this pull request Aug 24, 2024
@stenzek
Squashed 'third_party/spirv-headers/' changes from 2acb319af..f013f08e4
af61294 
f013f08e4 Add missing OpUntypedPrefetchKHR (google#441)
a41bc926e VkspReflection non-sematic: add fields to DescriptorSetBuffer (google#440)
db5a00f8c Support for SPV_KHR_untyped_pointers (google#439)
3c355ec43 Reserve 4 memory operands bits for Arm (google#436)
41a8eb27f Update headers with SPIR-V version 1.6, revision 4. (google#437)

git-subtree-dir: third_party/spirv-headers
git-subtree-split: f013f08e4455bcc1f0eed8e3dd5e2009682656d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@antiagainst antiagainst antiagainst approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dneto0 @antiagainst