refactor: encapsulate getting the working directory in a helper function#961
Merged
another-rex merged 1 commit intogoogle:mainfrom May 6, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #961 +/- ##
==========================================
+ Coverage 63.67% 63.71% +0.03%
==========================================
Files 146 146
Lines 11960 11958 -2
==========================================
+ Hits 7616 7619 +3
+ Misses 3878 3875 -3
+ Partials 466 464 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e074cb4 to
f472991
Compare
hogo6002
approved these changes
May 6, 2024
another-rex
approved these changes
May 6, 2024
josieang
pushed a commit
to josieang/osv-scanner
that referenced
this pull request
Jun 6, 2024
…ion (google#961) This "improves" our coverage artificially since the unhappy path is not coverable and this reduces us from three uncoverable lines to one. I think this is worth doing as it feels more representative especially since we're panicking meaning we consider this a very unlikely and "on fire" situation, so we're hiding that within a particular function whose name makes that clear a la `regexp.MustCompile`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This "improves" our coverage artificially since the unhappy path is not coverable and this reduces us from three uncoverable lines to one.
I think this is worth doing as it feels more representative especially since we're panicking meaning we consider this a very unlikely and "on fire" situation, so we're hiding that within a particular function whose name makes that clear a la
regexp.MustCompile