Merged
Conversation
another-rex
approved these changes
May 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #960 +/- ##
==========================================
+ Coverage 63.67% 64.26% +0.58%
==========================================
Files 146 146
Lines 11960 9295 -2665
==========================================
- Hits 7616 5973 -1643
+ Misses 3878 2854 -1024
- Partials 466 468 +2 ☔ View full report in Codecov by Sentry. |
e8ca7ea to
61c3abf
Compare
josieang
pushed a commit
to josieang/osv-scanner
that referenced
this pull request
Jun 6, 2024
These got included in google#938 even though they're for google#937 and it seems that `go-snaps` does not error about this even though it will clean them up if run with `UPDATE_SNAPS=clean`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These got included in #938 even though they're for #937 and it seems that
go-snapsdoes not error about this even though it will clean them up if run withUPDATE_SNAPS=clean.