Skip to content

test: hide the cli help flag to avoid panic when running parallel#2279

Merged
another-rex merged 5 commits intogoogle:mainfrom
ackama:help/hide-help
Oct 16, 2025
Merged

test: hide the cli help flag to avoid panic when running parallel#2279
another-rex merged 5 commits intogoogle:mainfrom
ackama:help/hide-help

Conversation

@G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Oct 14, 2025

Unfortunately the upstream package does not feel there is a reason to remove their global help flag variable hack that can cause a panic when running in parallel, so this has us hide the help flag for all commands when running the tests so that the code path is skipped entirely

@G-Rath G-Rath force-pushed the help/hide-help branch 3 times, most recently from 3ca0d1b to d4d1ac4 Compare October 14, 2025 23:56
@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.71%. Comparing base (31aab3e) to head (97bbd08).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2279      +/-   ##
==========================================
+ Coverage   67.65%   67.71%   +0.05%     
==========================================
  Files         169      169              
  Lines       16319    16323       +4     
==========================================
+ Hits        11041    11053      +12     
+ Misses       4600     4592       -8     
  Partials      678      678              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@G-Rath G-Rath changed the title fix: hide help flag test: hide the cli help flag to avoid panic when running parallel Oct 15, 2025
@G-Rath G-Rath requested review from another-rex and cuixq October 15, 2025 18:20
@G-Rath G-Rath marked this pull request as ready for review October 15, 2025 18:21
Copy link
Collaborator

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@another-rex another-rex enabled auto-merge (squash) October 16, 2025 00:05
@another-rex another-rex merged commit bc7386f into google:main Oct 16, 2025
16 checks passed
@another-rex another-rex deleted the help/hide-help branch October 16, 2025 00:16
G-Rath added a commit to ackama/osv-scanner that referenced this pull request Nov 9, 2025
G-Rath added a commit to ackama/osv-scanner that referenced this pull request Nov 9, 2025
G-Rath added a commit to ackama/osv-scanner that referenced this pull request Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants