chore: Update go-sarif to v3 from v2#1985
Merged
another-rex merged 8 commits intogoogle:mainfrom Jun 25, 2025
Merged
Conversation
cuixq
approved these changes
Jun 20, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1985 +/- ##
==========================================
- Coverage 65.93% 65.38% -0.55%
==========================================
Files 168 174 +6
Lines 16154 17130 +976
==========================================
+ Hits 10651 11201 +550
- Misses 4844 5164 +320
- Partials 659 765 +106 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cuixq
approved these changes
Jun 23, 2025
another-rex
added a commit
to another-rex/osv-scanner
that referenced
this pull request
Jul 11, 2025
This reverts commit 24e8319.
another-rex
pushed a commit
that referenced
this pull request
Jul 15, 2025
… snap… (#2072) …shots Fixes #2071 I think the code and snapshots were updated as part of #1985, but the required "text" property in the *description fields was lost and not detected. I think this change restores the previous behaviour with respect to these fields - I can't yet be sure there are no other breaking changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated sarif library to v3 from v2. Still outputting SARIF 2.1 as that is what github supports.
I also changed how sarif_test snapshots are generated in the first commit to make it easier to see the diff, so when reviewing, please see the differences between the first commit and the last one for the snapshots, don't look at the full thing.
Currently it seems like there's an issue with ruleIndex being populated with -1 rather that the actual rule index, not sure why yet, I'll post an issue on the libraries repo.Solved! Updated to v3.2.0 which resolved the above issue.