[elfutils] turn on the alignment check#7092
Merged
DavidKorczynski merged 2 commits intogoogle:masterfrom Jan 5, 2022
Merged
Conversation
Unaligned access can crash code on some architectures like SPARC for example. The latest example (unrelated to elfutils) would be systemd/systemd#21935 (which UBSan could have easily prevented and which led to rolling out the check in the systemd project among other things). It should probably be merged once https://sourceware.org/bugzilla/show_bug.cgi?id=28720 is closed.
to make it easier to run the fuzzer with gdb locally.
keszybz
pushed a commit
to systemd/systemd
that referenced
this pull request
Jan 5, 2022
It was copy-pasted directly from OSS-Fuzz where it makes sense to kind of strip binaries to get nice backtraces but when the fuzzers are built and run locally with gdb it would be nice to have a little bit more than that. It was initially discovered in elfutils where I put the same flags and was surprised when I couldn't run the fuzzer comfortably step by step, which led to the same change there: google/oss-fuzz#7092 :-)
DavidKorczynski
approved these changes
Jan 5, 2022
evverx
added a commit
to evverx/elfutils
that referenced
this pull request
Jan 5, 2022
It's a follow-up to google/oss-fuzz#7092
evverx
added a commit
to evverx/elfutils
that referenced
this pull request
Jan 5, 2022
It's a follow-up to google/oss-fuzz#7092
Contributor
Author
|
Looks like that last issue was found and reported in https://oss-fuzz.com/testcase-detail/6013023414779904 but it hasn't been reported on Monorail. @jonathanmetzman I wonder if I should wait a bit longer for it to be reported there or considering that check is turned off by default should maybe a new crash signature be added somewhere? |
Contributor
Author
|
Judging by https://sourceware.org/pipermail/elfutils-devel/2022q1/004629.html it was reported on Monorail. |
evverx
added a commit
to evverx/elfutils
that referenced
this pull request
Jan 8, 2022
It's a follow-up to google/oss-fuzz#7092
evverx
added a commit
to evverx/elfutils
that referenced
this pull request
Jan 8, 2022
It's a follow-up to google/oss-fuzz#7092
evverx
added a commit
to evverx/elfutils
that referenced
this pull request
Mar 21, 2022
It's a follow-up to google/oss-fuzz#7092
evverx
added a commit
to evverx/elfutils
that referenced
this pull request
Mar 21, 2022
It's a follow-up to google/oss-fuzz#7092
MartinPetkov
pushed a commit
to MartinPetkov/oss-fuzz
that referenced
this pull request
Aug 15, 2022
* [elfutils] turn on the alignment check Unaligned access can crash code on some architectures like SPARC for example. The latest example (unrelated to elfutils) would be systemd/systemd#21935 (which UBSan could have easily prevented and which led to rolling out the check in the systemd project among other things). It should probably be merged once https://sourceware.org/bugzilla/show_bug.cgi?id=28720 is closed. * [elfutils] drop line-tables-only to make it easier to run the fuzzer with gdb locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unaligned access can crash code on some architectures like SPARC for example. The latest example (unrelated to elfutils) would be systemd/systemd#21935 (which UBSan could have easily prevented and which led to rolling out the check in the systemd project among other things).
It should probably be merged once https://sourceware.org/bugzilla/show_bug.cgi?id=28720 is closed.On second thought almost all of those issues have been fixed and at this point it seems it would make sense to merge it and wait for OSS-Fuzz to sort out duplicates automatically and report what's left.