-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add CPython as a project, with Gregory P. Smith as a contact. #583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Upstream issue to actually create tests: http://bugs.python.org/issue29505 (But they don't exist yet). There are some internal (YouTube) bugs for adding fuzz tests as well, to be done in that issue: b/37561297, b/37561383, b/37562501, b/37562550, b/37562021 I'd expect adding fuzz tests for this to be an ongoing project. :)
|
Main stuff I'm worried about: Does there need to be a separate directory for different (supported) versions of Python? 2 vs 3, or 3.5 vs 3.6? And: I'm genuinely worried that the overhead cost for CPython might be so big that most of it won't be usefully fuzzable. Not sure how to evaluate this stuff. |
You may technically do either way.
Can you explain? (And this PR is good to go, once we decide on how to name it (cpython, or python3, or ...) |
|
How much the overhead is going to be depends on how the fuzzers are written. I home if they're written as a C function which never drives the interpreter, just the C API for these modules, the overhead won't be too bad. If your target function involves running the core python VM ( |
|
I think python 2 and python 3 feel sufficiently different to be their own projects, you can rename cpython2 and cpython3. But i dont think we need to seperate 3.5 vs 3.6. We fuzz on trunk, so preferred to keep just 3.6. older version can go unmaintained and we don't want to fuzz and find old bugs. |
|
OK, I split it in half to cpython2 and cpython3 in another commit.
Yes! At least until python2 is retired. (EOL upstream is 2020 [at which point presumably someone else will take over maintaining it], EOL at Google is unknown to me.)
Yeah. For example, to fuzz hashing, we can do something like OTOH for some modules my initial drafts did involve running the interpreter. For example, the I don't think that should be a problem, though, since upstream is interested in fuzzing as far as I can tell. We'll find a way to make it work and get decent tests out of it. :) |
…#583) * Add CPython as a project, with Gregory P. Smith as a contact. Upstream issue to actually create tests: http://bugs.python.org/issue29505 (But they don't exist yet). There are some internal (YouTube) bugs for adding fuzz tests as well, to be done in that issue: b/37561297, b/37561383, b/37562501, b/37562550, b/37562021 I'd expect adding fuzz tests for this to be an ongoing project. :) * Split cpython into cpython2 and cpython3.
Upstream issue to actually create tests: http://bugs.python.org/issue29505
(But they don't exist yet).
There are some internal (YouTube) bugs for adding fuzz tests as well, to be done
in that issue: b/37561297, b/37561383, b/37562501, b/37562550, b/37562021
I'd expect adding fuzz tests for this to be an ongoing project. :)