askama: update used rust toolchain#13237
Merged
DavidKorczynski merged 1 commit intogoogle:masterfrom Apr 21, 2025
Merged
Conversation
The next version of askama (v0.14) will need at least rust 1.83 to compile. The current toolchain shipped in docker is rust 1.81, so the project could not get fuzzed anymore. This PR sets the used toolchain to 1.83.
|
Kijewski is either the primary contact or is in the CCs list of projects/askama. |
Contributor
Author
|
I am not sure if that is the right way to set the required rust version. I stole the diff from #12930. The log output shows that the newest nightly release was used: step:7:331. I would be OK with that, too, but I guess that only means that the CI here, and in our cluster-fuzz config (rust.yml#L284-L314) don't work the same? If someone more knowledgeable could please have a look? |
DavidKorczynski
approved these changes
Apr 21, 2025
Collaborator
DavidKorczynski
left a comment
There was a problem hiding this comment.
I think this should be good!
srividya-p
pushed a commit
to srividya-p/oss-fuzz
that referenced
this pull request
Apr 27, 2025
The next version of askama (v0.14) will need at least rust 1.83 to compile. The current toolchain shipped in docker is rust 1.81, so the project could not get fuzzed anymore. This PR sets the used toolchain to 1.83. Cc @GuillaumeGomez Related issue: <askama-rs/askama#405>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The next version of askama (v0.14) will need at least rust 1.83 to compile. The current toolchain shipped in docker is rust 1.81, so the project could not get fuzzed anymore.
This PR sets the used toolchain to 1.83.
Cc @GuillaumeGomez
Related issue: askama-rs/askama#405