Conversation
jsantell
added a commit
that referenced
this pull request
Nov 11, 2018
change, and fixes a CachedGLTFLoader instance issue from it sharing materials. Also disables a memory leak in background-image.
Merged
jsantell
added a commit
that referenced
this pull request
Nov 12, 2018
change, and fixes a CachedGLTFLoader instance issue from it sharing materials. Also disables a memory leak in background-image.
elalish
pushed a commit
to elalish/model-viewer
that referenced
this pull request
Feb 4, 2020
…skysphere depth test change, and fixes a CachedGLTFLoader instance issue from it sharing materials. Also disables a memory leak in background-image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Considering we're currently using a sphere as background which fills all the pixels there is no need to clear all the pixels.
@jsantell
multi-16.htmlcurrently has issues with thecamera.fara bit too tight and it's clipping the back of the background sphere. After this PR you'll see 2 astronauts in the top-right view. The second astronaut is from the previous rendered view.