Merged
Conversation
Contributor
jsantell
commented
Nov 11, 2018
- Broken out from Render fixes, HDR support, PMREM for correct radiance #133
- Fixes Investigate vanishing mesh #101, Changing background-image causes model to render strangely #120 render glitches from Avoid unnecessary framebuffer clears. #94/skysphere depth test change. I think this fixes all the weird rendering issues I've seen.
- Fixes CachedGLTFLoader instances sharing materials (and environment maps) resulting in race conditions to determine what envmap is displayed
change, and fixes a CachedGLTFLoader instance issue from it sharing materials. Also disables a memory leak in background-image.
cdata
approved these changes
Nov 11, 2018
Contributor
cdata
left a comment
There was a problem hiding this comment.
Thanks for breaking this out!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.