Skip to content

CPP: Fix typo in arguments to add_metadata_gen_target()#2874

Merged
penmetsaa merged 1 commit intogoogle:masterfrom
temideoye:cpp_fix-metadata-header-conflict
Jan 10, 2023
Merged

CPP: Fix typo in arguments to add_metadata_gen_target()#2874
penmetsaa merged 1 commit intogoogle:masterfrom
temideoye:cpp_fix-metadata-header-conflict

Conversation

@temideoye
Copy link
Copy Markdown
Contributor

@temideoye temideoye commented Jan 10, 2023

This commit resolves an issue with duplicate generation of metadata.h.

@temideoye
Fix typo in arguments to add_metadata_gen_target()
ce14569 
This commit resolves an issue with duplicate generation of metadata.h.
@temideoye temideoye changed the title Fix typo in arguments to add_metadata_gen_target() CPP: Fix typo in arguments to add_metadata_gen_target() Jan 10, 2023
@temideoye temideoye mentioned this pull request Jan 10, 2023
Merged
@penmetsaa penmetsaa merged commit 0ecc3d9 into google:master Jan 10, 2023
@Vogtinator
Copy link
Copy Markdown

Vogtinator commented Jun 14, 2023

This broke building here:

> cmake -DBUILD_STATIC_LIB=OFF -DBUILD_SHARED_LIB=ON -DBUILD_TESTING=ON -DBUILD_GEOCODER=OFF -DREGENERATE_METADATA=OFF ..
...
[   12s] [  2%] Generating Metadata code
[   12s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/libphonenumber-8.13.14/cpp/build'
[   12s] make[2]: Entering directory '/home/abuild/rpmbuild/BUILD/libphonenumber-8.13.14/cpp/build'
[   12s] cd /home/abuild/rpmbuild/BUILD/libphonenumber-8.13.14/cpp/build && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /home/abuild/rpmbuild/BUILD/libphonenumber-8.13.14/cpp /home/abuild/rpmbuild/BUILD/libphonenumber-8.13.14/cpp /home/abuild/rpmbuild/BUILD/libphonenumber-8.13.14/cpp/build /home/abuild/rpmbuild/BUILD/libphonenumber-8.13.14/cpp/build /home/abuild/rpmbuild/BUILD/libphonenumber-8.13.14/cpp/build/CMakeFiles/phonenumber_testing.dir/DependInfo.cmake
[   12s] Deleting primary custom command output "/home/abuild/rpmbuild/BUILD/libphonenumber-8.13.14/cpp/src/phonenumbers/test_metadata.cc" because another output "/home/abuild/rpmbuild/BUILD/libphonenumber-8.13.14/cpp/src/phonenumbers/test_metadata.h" does not exist.
...
[   16s] [ 38%] Building CXX object CMakeFiles/phonenumber_testing.dir/src/phonenumbers/test_metadata.cc.o
[   16s] /usr/bin/c++ -DBOOST_DATE_TIME_DYN_LINK -DBOOST_DATE_TIME_NO_LIB -DBOOST_SYSTEM_DYN_LINK -DBOOST_SYSTEM_NO_LIB -DBOOST_THREAD_DYN_LINK -DBOOST_THREAD_NO_LIB -DI18N_PHONENUMBERS_USE_ALTERNATE_FORMATS -DI18N_PHONENUMBERS_USE_BOOST -DI18N_PHONENUMBERS_USE_ICU_REGEXP -DI18N_PHONENUMBERS_USE_TR1_UNORDERED_MAP -I/home/abuild/rpmbuild/BUILD/libphonenumber-8.13.14/cpp/src -I/home/abuild/rpmbuild/BUILD/libphonenumber-8.13.14/cpp/test -O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -O2 -g -DNDEBUG -std=gnu++17 -fPIC   -Wall -Werror -MD -MT CMakeFiles/phonenumber_testing.dir/src/phonenumbers/test_metadata.cc.o -MF CMakeFiles/phonenumber_testing.dir/src/phonenumbers/test_metadata.cc.o.d -o CMakeFiles/phonenumber_testing.dir/src/phonenumbers/test_metadata.cc.o -c /home/abuild/rpmbuild/BUILD/libphonenumber-8.13.14/cpp/src/phonenumbers/test_metadata.cc
[   16s] cc1plus: fatal error: /home/abuild/rpmbuild/BUILD/libphonenumber-8.13.14/cpp/src/phonenumbers/test_metadata.cc: No such file or directory
[   16s] compilation terminated.

Reverting this commit fixes it.

@Vogtinator
Copy link
Copy Markdown

Vogtinator commented Sep 12, 2023

Ping ^

1 similar comment
@Vogtinator
Copy link
Copy Markdown

Vogtinator commented Feb 22, 2024

Ping ^

@Vogtinator
Copy link
Copy Markdown

Vogtinator commented Feb 22, 2024

This PR is broken, please revert...

@Vogtinator
Copy link
Copy Markdown

Vogtinator commented Jan 27, 2025

This PR is broken, please revert...

Ping.

@Vogtinator
Copy link
Copy Markdown

Vogtinator commented Jan 27, 2025

@penmetsaa ^

@Vogtinator
Copy link
Copy Markdown

Vogtinator commented Jul 23, 2025

Ping

Vogtinator added a commit to Vogtinator/libphonenumber that referenced this pull request Jul 23, 2025
@Vogtinator
Revert "Fix typo in arguments to add_metadata_gen_target() (google#2874…
1f1f068 
…)"

This reverts commit 0ecc3d9.
@Vogtinator
Copy link
Copy Markdown

Vogtinator commented Sep 15, 2025

Ping

@Vogtinator
Copy link
Copy Markdown

Vogtinator commented Sep 15, 2025

@penmetsaa @temideoye ^

@Vogtinator
Copy link
Copy Markdown

Vogtinator commented Feb 16, 2026

Ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@penmetsaa penmetsaa penmetsaa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@temideoye @Vogtinator @penmetsaa