Skip to content

CPP: Add BUILD_TOOLS_ONLY option#2869

Merged
penmetsaa merged 2 commits intogoogle:masterfrom
temideoye:cpp_add-build-tools-only-option
Jan 5, 2023
Merged

CPP: Add BUILD_TOOLS_ONLY option#2869
penmetsaa merged 2 commits intogoogle:masterfrom
temideoye:cpp_add-build-tools-only-option

Conversation

@temideoye
Copy link
Copy Markdown
Contributor

@temideoye temideoye commented Jan 5, 2023

  • The project currently fails to find abseil and gtest while building libphonenumber/tools/cpp because dependency resolutions have been consolidated in libphonenumber/cpp. This commit proposes a BUILD_TOOLS_ONLY option be added to the main project to allow building tools/cpp without duplicating common dependencies.
  • In essence, to build libphonenumber/tools/cpp, do cmake -S "path/to/libphonenumber/cpp" -DBUILD_TOOLS_ONLY=ON
  • This also solves the issue of "Absl not being able to Install in super builds"

@temideoye temideoye changed the title Add BUILD_TOOLS_ONLY option CPP: Add BUILD_TOOLS_ONLY option Jan 5, 2023
@penmetsaa penmetsaa self-requested a review January 5, 2023 08:38
@penmetsaa
Copy link
Copy Markdown
Contributor

Thanks much for the patch @temideoye ..
It definately helps us in fixing the build issue.
We will definately let you know if you we would still like trigger the build of Build tools separately.
Mostly not needed as far as I know.

@penmetsaa penmetsaa merged commit 74686a8 into google:master Jan 5, 2023
Sandeep-Vonage added a commit to Sandeep-Vonage/libphonenumber that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants