KSP2: clean up legacy incremental code#2231
Merged
Merged
Conversation
which was an lefe-over when moving to IncrementalGlobalSearchScope. It also causes a problem when users wire generated outputs to source sets.
eygraber
added a commit
to eygraber/kotlin-inject
that referenced
this pull request
Nov 23, 2024
- Avoids issues until google/ksp#2231 is released
eygraber
added a commit
to eygraber/kotlin-inject
that referenced
this pull request
Nov 24, 2024
- Avoids issues until google/ksp#2231 is released
evant
pushed a commit
to evant/kotlin-inject
that referenced
this pull request
Jan 10, 2025
* Enable KSP2 * Remove val from function parameter in test * Use messagesWithSeverity for tests * Kotlin 2.0.21 * Update yarn.lock * Don't cache elements across rounds * Fix test failures due to logging * Fix typealiases for function injection * Fix typealiases with type parameters * KSP2 returns synthetic constructors for objects * Defer all KmpComponentCreate functions to the last round * Handle typealias to typealias * Added a KSP1 target for unit tests * Add KSP1 integration tests * Clean in between assemble and check on CI - Avoids issues until google/ksp#2231 is released * Update Kotlin to 2.1.0 * Update KSP to 2.1.0-1.0.29 * Update kotlin-compile-testing * Rename resolveToHighestTypeAlias for clarity * Remove unused property
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
which was an lefe-over when moving to IncrementalGlobalSearchScope.
It also causes a problem when users wire generated outputs to source sets.
Prevents #2230