Missing masterPassword input in post.go#971
Missing masterPassword input in post.go#971gdbelvin merged 1 commit intogoogle:masterfrom weikengchen:patch-1
Conversation
Just start to try Key Transparency (just work-in-progress? I can't wait to use it) I find that when I want to post a public key, there will be a notice "please enter a master key", but post.go does not accept the password `-p` as input.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
A side question: is Key Transparency ready to an extent that a class project can launch a server and create a local key Merkle tree? |
|
CLAs look good, thanks! |
Codecov Report
@@ Coverage Diff @@
## master #971 +/- ##
=======================================
Coverage 47.34% 47.34%
=======================================
Files 28 28
Lines 2034 2034
=======================================
Hits 963 963
Misses 894 894
Partials 177 177Continue to review full report at Codecov.
|
|
Hi @weikengchen, thanks for spotting and fixing this! Key Transparency is ready for prototyping and classroom use. |
…y into test/listhistory * 'test/listhistory' of github.com:gdbelvin/keytransparency: Missing masterPassword input in post.go (google#971)
Just start to try Key Transparency (just work-in-progress? I can't wait to use it)
I find that when I want to post a public key, there will be a notice "please enter a master key", but post.go does not accept the password
-pas input.