switch to an internal annotation for ignoring JRE requirements #3652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
(Thanks!) |
Merged
nick-someone
pushed a commit
that referenced
this pull request
Oct 11, 2019
requirements Fixes #3652 RELNOTES=Removed dependency on `animal-sniffer-annotations`. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=273964192
nick-someone
pushed a commit
that referenced
this pull request
Oct 11, 2019
requirements Fixes #3652 RELNOTES=Removed dependency on `animal-sniffer-annotations`. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=273964192
This was referenced Oct 16, 2019
copybara-service bot
pushed a commit
to google/truth
that referenced
this pull request
Jul 2, 2025
I can't remember offhand if I wanted that support before. Maybe? But it became possible way back in mojohaus/animal-sniffer#212. I guess this qualifies as the "nightmare scenario" for having our own versions of the annotation (google/guava#3649, google/guava#3652) :) It hardly matters. RELNOTES=n/a PiperOrigin-RevId: 778562698
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 2, 2025
I can't remember offhand if I wanted that support before. Maybe? But it became possible way back in mojohaus/animal-sniffer#212. I guess this qualifies as the "nightmare scenario" for having our own versions of the annotation (#3649, #3652) :) It hardly matters. RELNOTES=n/a PiperOrigin-RevId: 778562698
copybara-service bot
pushed a commit
to google/truth
that referenced
this pull request
Jul 2, 2025
I can't remember offhand if I wanted that support before. Maybe? But it became possible way back in mojohaus/animal-sniffer#212. I guess this qualifies as the "nightmare scenario" for having our own versions of the annotation (google/guava#3649, google/guava#3652) :) It hardly matters. RELNOTES=n/a PiperOrigin-RevId: 778575641
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 2, 2025
I can't remember offhand if I wanted that support before. Maybe? But it became possible way back in mojohaus/animal-sniffer#212. I guess this qualifies as the "nightmare scenario" for having our own versions of the annotation (#3649, #3652) :) It hardly matters. RELNOTES=n/a PiperOrigin-RevId: 778575641
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cpovirk This completely removes the dependency on animal-sniffer annotations