added support for sflow ethernet frame flows#574
Merged
notti merged 2 commits intogoogle:masterfrom Dec 23, 2018
jpbede:sflow-ethernet-frame
Merged
added support for sflow ethernet frame flows#574notti merged 2 commits intogoogle:masterfrom jpbede:sflow-ethernet-frame
notti merged 2 commits intogoogle:masterfrom
jpbede:sflow-ethernet-frame
Conversation
notti
suggested changes
Dec 21, 2018
Contributor
notti
left a comment
There was a problem hiding this comment.
Looks good. Could you also add a testcase to sflow_test.go?
Contributor
Author
|
I've added now a test with data from a live network. |
jpbede
commented
Dec 22, 2018
Contributor
Author
jpbede
left a comment
There was a problem hiding this comment.
I've added now a test with data from a live network.
I've also added a field that i've forgotten.
notti
approved these changes
Dec 23, 2018
Contributor
|
Thanks for the contribution. |
traetox
pushed a commit
to traetox/gopacket
that referenced
this pull request
Jan 2, 2019
added support for sflow ethernet frame flows
traetox
pushed a commit
to traetox/gopacket
that referenced
this pull request
Jan 2, 2019
added support for sflow ethernet frame flows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for sFlow ethernet frame flows