Skip to content

Issue 709: Fix Cmake policy 0048#782

Merged
gennadiycivil merged 1 commit intogoogle:masterfrom
Manozco:709-cmake-policy-project-version
Aug 2, 2017
Merged

Issue 709: Fix Cmake policy 0048#782
gennadiycivil merged 1 commit intogoogle:masterfrom
Manozco:709-cmake-policy-project-version

Conversation

@Manozco
Copy link
Copy Markdown
Contributor

@Manozco Manozco commented May 22, 2016

Fix issue: #709

@googlebot
Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@Manozco
Copy link
Copy Markdown
Contributor Author

Manozco commented May 22, 2016

CLA updated, everything should be fine now

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@KingDuckZ
Copy link
Copy Markdown

Any news on this?

@Manozco
Copy link
Copy Markdown
Contributor Author

Manozco commented Jul 14, 2016

It's still ready to be merged I think

sevanspowell pushed a commit to sevanspowell/googletest that referenced this pull request Nov 19, 2016
@dcrankshaw
Copy link
Copy Markdown

Any updates on this?

@KingDuckZ
Copy link
Copy Markdown

Still unmerged? I've moved to Catch since when I first reported this problem, but I think it's still nice if it could get fixed.

@ikoruk
Copy link
Copy Markdown

ikoruk commented Apr 5, 2017

This is a one-line commit that fixes a warning for every user of this library, I don't see why 10 months later it still hasn't been merged.

@rossctaylor
Copy link
Copy Markdown

This change breaks GTest for older versions of CMake (prior to 3.0) that don't know about this policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants