Skip to content

Fix warning maybe-uninitialized#3024

Merged
suertreus merged 1 commit intogoogle:masterfrom
Thomas-Barbier-1A:fix_warning_maybe_unintialized
Sep 30, 2020
Merged

Fix warning maybe-uninitialized#3024
suertreus merged 1 commit intogoogle:masterfrom
Thomas-Barbier-1A:fix_warning_maybe_unintialized

Conversation

@Thomas-Barbier-1A
Copy link
Copy Markdown
Contributor

@Thomas-Barbier-1A Thomas-Barbier-1A commented Sep 24, 2020

No description provided.

@google-cla google-cla bot added the cla: yes label Sep 24, 2020
@Maximuscari205
Copy link
Copy Markdown

Maximuscari205 commented Sep 26, 2020

Fixed

@Thomas-Barbier-1A
Copy link
Copy Markdown
Contributor Author

Thomas-Barbier-1A commented Sep 28, 2020

@Maximuscari205 which commit fix it? I still have the issue with Head of master with gcc (GCC) 11.0.0 20200803
I think this PR is necessary to fix the issue.

@derekmauro derekmauro self-assigned this Sep 29, 2020
suertreus added a commit that referenced this pull request Sep 29, 2020
@suertreus
Merge pull request #3024 from Thomas-Barbier-1A:fix_warning_maybe_uni…
3d0c981 
…ntialized

PiperOrigin-RevId: 334391149
@suertreus suertreus merged commit a0cbbba into google:master Sep 30, 2020
@Thomas-Barbier-1A Thomas-Barbier-1A deleted the fix_warning_maybe_unintialized branch September 30, 2020 08:19
tchaikov added a commit to tchaikov/ceph that referenced this pull request Jan 6, 2021
@tchaikov
googletest: pick up change to silence error=maybe-uninitialized warning
7fd9d8a 
to include the fix of google/googletest#3024

otherwise GCC-11 fails to compile the tests with following warning:

In file included from ../src/googletest/googletest/src/gtest-all.cc:42:
../src/googletest/googletest/src/gtest-death-test.cc: In function ‘bool testing::internal::StackGrowsDown()’:
../src/googletest/googletest/src/gtest-death-test.cc:1301:24: error: ‘dummy’ may be used uninitialized [-Werror=maybe-uninitialized]
 1301 |   StackLowerThanAddress(&dummy, &result);
      |   ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1290:13: note: by argument 1 of type ‘const void*’ to ‘void testing::internal::StackLowerThanAddress(const void*, bool*)’ declared here
 1290 | static void StackLowerThanAddress(const void* ptr, bool* result) {
      |             ^~~~~~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1299:7: note: ‘dummy’ declared here
 1299 |   int dummy;
      |       ^~~~~
cc1plus: all warnings being treated as errors

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov tchaikov mentioned this pull request Jan 6, 2021
Merged
3 tasks
tchaikov added a commit to tchaikov/ceph that referenced this pull request Jan 6, 2021
@tchaikov
googletest: pick up change to silence error=maybe-uninitialized warning
89c8f41 
to include the fix of google/googletest#3024.
because this fix is not included in the latest release (1.10.0) of
googletest yet at the time of writing. the submodule is referencing the
latest master HEAD of google/googletest.

otherwise GCC-11 fails to compile the tests with following warning:

In file included from ../src/googletest/googletest/src/gtest-all.cc:42:
../src/googletest/googletest/src/gtest-death-test.cc: In function ‘bool testing::internal::StackGrowsDown()’:
../src/googletest/googletest/src/gtest-death-test.cc:1301:24: error: ‘dummy’ may be used uninitialized [-Werror=maybe-uninitialized]
 1301 |   StackLowerThanAddress(&dummy, &result);
      |   ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1290:13: note: by argument 1 of type ‘const void*’ to ‘void testing::internal::StackLowerThanAddress(const void*, bool*)’ declared here
 1290 | static void StackLowerThanAddress(const void* ptr, bool* result) {
      |             ^~~~~~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1299:7: note: ‘dummy’ declared here
 1299 |   int dummy;
      |       ^~~~~
cc1plus: all warnings being treated as errors

Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov added a commit to tchaikov/ceph that referenced this pull request Jan 6, 2021
@tchaikov
googletest: pick up change to silence error=maybe-uninitialized warning
8e85c8c 
to include the fix of google/googletest#3024

otherwise GCC-11 fails to compile the tests with following warning:

In file included from ../src/googletest/googletest/src/gtest-all.cc:42:
../src/googletest/googletest/src/gtest-death-test.cc: In function ‘bool testing::internal::StackGrowsDown()’:
../src/googletest/googletest/src/gtest-death-test.cc:1301:24: error: ‘dummy’ may be used uninitialized [-Werror=maybe-uninitialized]
 1301 |   StackLowerThanAddress(&dummy, &result);
      |   ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1290:13: note: by argument 1 of type ‘const void*’ to ‘void testing::internal::StackLowerThanAddress(const void*, bool*)’ declared here
 1290 | static void StackLowerThanAddress(const void* ptr, bool* result) {
      |             ^~~~~~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1299:7: note: ‘dummy’ declared here
 1299 |   int dummy;
      |       ^~~~~
cc1plus: all warnings being treated as errors

Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov added a commit to tchaikov/ceph that referenced this pull request Jan 7, 2021
@tchaikov
googletest: pick up change to silence error=maybe-uninitialized warning
3dcfd13 
to include the fix of google/googletest#3024

otherwise GCC-11 fails to compile the tests with following warning:

In file included from ../src/googletest/googletest/src/gtest-all.cc:42:
../src/googletest/googletest/src/gtest-death-test.cc: In function ‘bool testing::internal::StackGrowsDown()’:
../src/googletest/googletest/src/gtest-death-test.cc:1301:24: error: ‘dummy’ may be used uninitialized [-Werror=maybe-uninitialized]
 1301 |   StackLowerThanAddress(&dummy, &result);
      |   ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1290:13: note: by argument 1 of type ‘const void*’ to ‘void testing::internal::StackLowerThanAddress(const void*, bool*)’ declared here
 1290 | static void StackLowerThanAddress(const void* ptr, bool* result) {
      |             ^~~~~~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1299:7: note: ‘dummy’ declared here
 1299 |   int dummy;
      |       ^~~~~
cc1plus: all warnings being treated as errors

Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov added a commit to tchaikov/ceph that referenced this pull request Jan 7, 2021
@tchaikov
googletest: pick up change to silence error=maybe-uninitialized warning
df6cfb6 
to include the fix of google/googletest#3024

otherwise GCC-11 fails to compile the tests with following warning:

In file included from ../src/googletest/googletest/src/gtest-all.cc:42:
../src/googletest/googletest/src/gtest-death-test.cc: In function ‘bool testing::internal::StackGrowsDown()’:
../src/googletest/googletest/src/gtest-death-test.cc:1301:24: error: ‘dummy’ may be used uninitialized [-Werror=maybe-uninitialized]
 1301 |   StackLowerThanAddress(&dummy, &result);
      |   ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1290:13: note: by argument 1 of type ‘const void*’ to ‘void testing::internal::StackLowerThanAddress(const void*, bool*)’ declared here
 1290 | static void StackLowerThanAddress(const void* ptr, bool* result) {
      |             ^~~~~~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1299:7: note: ‘dummy’ declared here
 1299 |   int dummy;
      |       ^~~~~
cc1plus: all warnings being treated as errors

Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov added a commit to tchaikov/ceph that referenced this pull request Jan 7, 2021
@tchaikov
googletest: pick up change to silence error=maybe-uninitialized warning
0b92eb2 
to include the fix of google/googletest#3024

otherwise GCC-11 fails to compile the tests with following warning:

In file included from ../src/googletest/googletest/src/gtest-all.cc:42:
../src/googletest/googletest/src/gtest-death-test.cc: In function ‘bool testing::internal::StackGrowsDown()’:
../src/googletest/googletest/src/gtest-death-test.cc:1301:24: error: ‘dummy’ may be used uninitialized [-Werror=maybe-uninitialized]
 1301 |   StackLowerThanAddress(&dummy, &result);
      |   ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1290:13: note: by argument 1 of type ‘const void*’ to ‘void testing::internal::StackLowerThanAddress(const void*, bool*)’ declared here
 1290 | static void StackLowerThanAddress(const void* ptr, bool* result) {
      |             ^~~~~~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1299:7: note: ‘dummy’ declared here
 1299 |   int dummy;
      |       ^~~~~
cc1plus: all warnings being treated as errors

Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov added a commit to tchaikov/ceph that referenced this pull request Jan 7, 2021
@tchaikov
googletest: pick up change to silence error=maybe-uninitialized warning
3d10f23 
to include the fix of google/googletest#3024

otherwise GCC-11 fails to compile the tests with following warning:

In file included from ../src/googletest/googletest/src/gtest-all.cc:42:
../src/googletest/googletest/src/gtest-death-test.cc: In function ‘bool testing::internal::StackGrowsDown()’:
../src/googletest/googletest/src/gtest-death-test.cc:1301:24: error: ‘dummy’ may be used uninitialized [-Werror=maybe-uninitialized]
 1301 |   StackLowerThanAddress(&dummy, &result);
      |   ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1290:13: note: by argument 1 of type ‘const void*’ to ‘void testing::internal::StackLowerThanAddress(const void*, bool*)’ declared here
 1290 | static void StackLowerThanAddress(const void* ptr, bool* result) {
      |             ^~~~~~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1299:7: note: ‘dummy’ declared here
 1299 |   int dummy;
      |       ^~~~~
cc1plus: all warnings being treated as errors

Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov added a commit to tchaikov/ceph that referenced this pull request Jan 7, 2021
@tchaikov
googletest: pick up change to silence error=maybe-uninitialized warning
357ac1e 
to include the fix of google/googletest#3024

otherwise GCC-11 fails to compile the tests with following warning:

In file included from ../src/googletest/googletest/src/gtest-all.cc:42:
../src/googletest/googletest/src/gtest-death-test.cc: In function ‘bool testing::internal::StackGrowsDown()’:
../src/googletest/googletest/src/gtest-death-test.cc:1301:24: error: ‘dummy’ may be used uninitialized [-Werror=maybe-uninitialized]
 1301 |   StackLowerThanAddress(&dummy, &result);
      |   ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1290:13: note: by argument 1 of type ‘const void*’ to ‘void testing::internal::StackLowerThanAddress(const void*, bool*)’ declared here
 1290 | static void StackLowerThanAddress(const void* ptr, bool* result) {
      |             ^~~~~~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1299:7: note: ‘dummy’ declared here
 1299 |   int dummy;
      |       ^~~~~
cc1plus: all warnings being treated as errors

Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov added a commit to tchaikov/ceph that referenced this pull request Jan 8, 2021
@tchaikov
googletest: pick up change to silence error=maybe-uninitialized warning
abbdf33 
to include the fix of google/googletest#3024

otherwise GCC-11 fails to compile the tests with following warning:

In file included from ../src/googletest/googletest/src/gtest-all.cc:42:
../src/googletest/googletest/src/gtest-death-test.cc: In function ‘bool testing::internal::StackGrowsDown()’:
../src/googletest/googletest/src/gtest-death-test.cc:1301:24: error: ‘dummy’ may be used uninitialized [-Werror=maybe-uninitialized]
 1301 |   StackLowerThanAddress(&dummy, &result);
      |   ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1290:13: note: by argument 1 of type ‘const void*’ to ‘void testing::internal::StackLowerThanAddress(const void*, bool*)’ declared here
 1290 | static void StackLowerThanAddress(const void* ptr, bool* result) {
      |             ^~~~~~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1299:7: note: ‘dummy’ declared here
 1299 |   int dummy;
      |       ^~~~~
cc1plus: all warnings being treated as errors

Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov added a commit to tchaikov/ceph that referenced this pull request Jan 8, 2021
@tchaikov
googletest: pick up change to silence error=maybe-uninitialized warning
664bfb3 
to include the fix of google/googletest#3024

otherwise GCC-11 fails to compile the tests with following warning:

In file included from ../src/googletest/googletest/src/gtest-all.cc:42:
../src/googletest/googletest/src/gtest-death-test.cc: In function ‘bool testing::internal::StackGrowsDown()’:
../src/googletest/googletest/src/gtest-death-test.cc:1301:24: error: ‘dummy’ may be used uninitialized [-Werror=maybe-uninitialized]
 1301 |   StackLowerThanAddress(&dummy, &result);
      |   ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1290:13: note: by argument 1 of type ‘const void*’ to ‘void testing::internal::StackLowerThanAddress(const void*, bool*)’ declared here
 1290 | static void StackLowerThanAddress(const void* ptr, bool* result) {
      |             ^~~~~~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1299:7: note: ‘dummy’ declared here
 1299 |   int dummy;
      |       ^~~~~
cc1plus: all warnings being treated as errors

Signed-off-by: Kefu Chai <kchai@redhat.com>
@ghost ghost mentioned this pull request Jan 14, 2021
Closed
hejllukas added a commit to prusa3d/PrusaSlicer that referenced this pull request May 1, 2021
@hejllukas
Fixed compilation issue with GoogleTest on GCC 11.1.
d38e3ed 
It was added patch from google/googletest#3024 to silence error=maybe-uninitialized warning.
@homalozoa homalozoa mentioned this pull request May 22, 2021
Merged
tchaikov added a commit to tchaikov/ceph that referenced this pull request May 25, 2021
@tchaikov
googletest: pick up change to silence error=maybe-uninitialized warning
1c611ac 
to include the fix of google/googletest#3024

otherwise GCC-11 fails to compile the tests with following warning:

In file included from ../src/googletest/googletest/src/gtest-all.cc:42:
../src/googletest/googletest/src/gtest-death-test.cc: In function ‘bool testing::internal::StackGrowsDown()’:
../src/googletest/googletest/src/gtest-death-test.cc:1301:24: error: ‘dummy’ may be used uninitialized [-Werror=maybe-uninitialized]
 1301 |   StackLowerThanAddress(&dummy, &result);
      |   ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1290:13: note: by argument 1 of type ‘const void*’ to ‘void testing::internal::StackLowerThanAddress(const void*, bool*)’ declared here
 1290 | static void StackLowerThanAddress(const void* ptr, bool* result) {
      |             ^~~~~~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1299:7: note: ‘dummy’ declared here
 1299 |   int dummy;
      |       ^~~~~
cc1plus: all warnings being treated as errors

Signed-off-by: Kefu Chai <kchai@redhat.com>
@clalancette clalancette mentioned this pull request Jun 1, 2021
Merged
hejllukas added a commit to prusa3d/PrusaSlicer that referenced this pull request Jun 26, 2021
@hejllukas
Fixed compilation issue with GoogleTest on GCC 11.1.
b07de60 
It was added patch from google/googletest#3024 to silence error=maybe-uninitialized warning.
@guillaumeblanc guillaumeblanc mentioned this pull request Jul 6, 2021
Closed
hejllukas added a commit to prusa3d/PrusaSlicer that referenced this pull request Jul 12, 2021
@hejllukas
Fixed compilation issue with GoogleTest on GCC 11.1.
ad382f4 
It was added patch from google/googletest#3024 to silence error=maybe-uninitialized warning.
@The-Compiler The-Compiler mentioned this pull request Sep 3, 2021
Closed
@dmitrykobets-msft dmitrykobets-msft mentioned this pull request Nov 15, 2021
Merged
zrax added a commit to zrax/string_theory that referenced this pull request May 11, 2022
@zrax
Backport google/googletest#3024 to fix warning on GCC11+
5498e95
zdover23 pushed a commit to zdover23/ceph that referenced this pull request May 17, 2022
@tchaikov
googletest submodule: pick up change to silence error=maybe-uninitial…
270ade1 
…ized warning

to include the fix of google/googletest#3024

otherwise GCC-11 fails to compile the tests with following warning:

In file included from ../src/googletest/googletest/src/gtest-all.cc:42:
../src/googletest/googletest/src/gtest-death-test.cc: In function ‘bool testing::internal::StackGrowsDown()’:
../src/googletest/googletest/src/gtest-death-test.cc:1301:24: error: ‘dummy’ may be used uninitialized [-Werror=maybe-uninitialized]
 1301 |   StackLowerThanAddress(&dummy, &result);
      |   ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1290:13: note: by argument 1 of type ‘const void*’ to ‘void testing::internal::StackLowerThanAddress(const void*, bool*)’ declared here
 1290 | static void StackLowerThanAddress(const void* ptr, bool* result) {
      |             ^~~~~~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1299:7: note: ‘dummy’ declared here
 1299 |   int dummy;
      |       ^~~~~
cc1plus: all warnings being treated as errors

Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit abbdf33)
@kentanabe kentanabe mentioned this pull request Aug 15, 2022
Open
webcat359 added a commit to webcat359/wallet-core that referenced this pull request Aug 29, 2022
@webcat359
update googletest to 1.11.0 (#1916)
4186842 
This fixes a build issue caused by gcc 11 changing the rules about what constitutes a `-Werror=maybe-uninitialized` error (see google/googletest#3024)
As a side benefit, this simplifies the build  script by removing the need for a few patches.
@caspervdw caspervdw mentioned this pull request Oct 10, 2022
Merged
@flomnes flomnes mentioned this pull request Oct 10, 2022
Closed
@algoriddle algoriddle mentioned this pull request Oct 19, 2022
Closed
algoriddle added a commit to algoriddle/faiss that referenced this pull request Oct 19, 2022
@algoriddle @facebook-github-bot
bumping gtest to 1.12.1
a98abd2 
Summary:
Due to google/googletest#3219 gtest doesn't compile with gcc 11 - Ubuntu 22.04 has GCC 11.2 currently.

The fix was google/googletest#3024 so I'm bumping gtest to latest.

Differential Revision: D40512746

fbshipit-source-id: b938eec96f0cb6e13e20daab529f97527c8e31c0
facebook-github-bot pushed a commit to facebookresearch/faiss that referenced this pull request Oct 20, 2022
@algoriddle @facebook-github-bot
bumping gtest to 1.12.1 (#2538)
a85aea9 
Summary:
Pull Request resolved: #2538

Due to google/googletest#3219 gtest doesn't compile with gcc 11 - Ubuntu 22.04 has GCC 11.2 currently.

The fix was google/googletest#3024 so I'm bumping gtest to latest.

Reviewed By: alexanderguzhva

Differential Revision: D40512746

fbshipit-source-id: 75f3c3c7f8a117af8430c2f74a7f8d164ca9877b
Ninja-21-dev added a commit to Ninja-21-dev/core-cross-blockchain-wallet that referenced this pull request Oct 28, 2022
@Ninja-21-dev
update googletest to 1.11.0 (#1916)
bcb526e 
This fixes a build issue caused by gcc 11 changing the rules about what constitutes a `-Werror=maybe-uninitialized` error (see google/googletest#3024)
As a side benefit, this simplifies the build  script by removing the need for a few patches.
@aneshlya aneshlya mentioned this pull request Nov 10, 2022
Merged
tomjnixon added a commit to ebu/ear-production-suite that referenced this pull request Nov 14, 2022
@tomjnixon
upgrade gtest to 1.11.0 for gcc11 fixes
369c182 
see google/googletest#3024
tomjnixon added a commit to ebu/ear-production-suite that referenced this pull request Nov 14, 2022
@tomjnixon
upgrade gtest to 1.11.0 for gcc11 fixes
e35ad62 
see google/googletest#3024
tomjnixon added a commit to ebu/ear-production-suite that referenced this pull request Nov 17, 2022
@tomjnixon
upgrade gtest to 1.11.0 for gcc11 fixes
e1c1ce6 
see google/googletest#3024
@lalitb lalitb mentioned this pull request Nov 22, 2022
Closed
@gjvc gjvc mentioned this pull request Dec 20, 2022
Closed
crazycodecreator007 added a commit to crazycodecreator007/core-wallet that referenced this pull request Feb 8, 2023
@crazycodecreator007
update googletest to 1.11.0 (#1916)
4202a42 
This fixes a build issue caused by gcc 11 changing the rules about what constitutes a `-Werror=maybe-uninitialized` error (see google/googletest#3024)
As a side benefit, this simplifies the build  script by removing the need for a few patches.
@gjvc gjvc mentioned this pull request Jun 23, 2023
Closed
BerndDoser added a commit to HITS-MBM/gromacs-fda that referenced this pull request Jul 13, 2023
@BerndDoser
Fix google test warning maybe-uninitialized
1f1c52a 
See google/googletest#3024
@HarshGandhi-AWS HarshGandhi-AWS mentioned this pull request Oct 13, 2023
Closed
@martinaxgloria martinaxgloria mentioned this pull request Nov 14, 2023
Closed
@zhangyi1357 zhangyi1357 mentioned this pull request Aug 7, 2024
Closed
Herocoin816 added a commit to Herocoin816/Wallet that referenced this pull request Sep 16, 2024
@Herocoin816
update googletest to 1.11.0 (#1916)
950aa1b 
This fixes a build issue caused by gcc 11 changing the rules about what constitutes a `-Werror=maybe-uninitialized` error (see google/googletest#3024)
As a side benefit, this simplifies the build  script by removing the need for a few patches.
gncao523 added a commit to gncao523/core-wallet that referenced this pull request Nov 15, 2024
@gncao523
update googletest to 1.11.0 (#1916)
81440df 
This fixes a build issue caused by gcc 11 changing the rules about what constitutes a `-Werror=maybe-uninitialized` error (see google/googletest#3024)
As a side benefit, this simplifies the build  script by removing the need for a few patches.
@fthdrmzzz fthdrmzzz mentioned this pull request Dec 11, 2024
Open
@insomniacslk insomniacslk mentioned this pull request Dec 19, 2024
Merged
christophehaight0307 pushed a commit to christophehaight0307/core-wallet that referenced this pull request Jan 21, 2025
@christophehaight0307-git
update googletest to 1.11.0 (#1916)
774b53e 
This fixes a build issue caused by gcc 11 changing the rules about what constitutes a `-Werror=maybe-uninitialized` error (see google/googletest#3024)
As a side benefit, this simplifies the build  script by removing the need for a few patches.
emglab01 added a commit to emglab01/wallet that referenced this pull request Feb 10, 2025
@emglab01
update googletest to 1.11.0 (#1916)
0bcc593 
This fixes a build issue caused by gcc 11 changing the rules about what constitutes a `-Werror=maybe-uninitialized` error (see google/googletest#3024)
As a side benefit, this simplifies the build  script by removing the need for a few patches.
sparkrider added a commit to sparkrider/trustwallet-core that referenced this pull request Feb 18, 2025
@sparkrider
update googletest to 1.11.0 (#1916)
59145e7 
This fixes a build issue caused by gcc 11 changing the rules about what constitutes a `-Werror=maybe-uninitialized` error (see google/googletest#3024)
As a side benefit, this simplifies the build  script by removing the need for a few patches.
BZO95 added a commit to BZO95/faiss that referenced this pull request Apr 10, 2025
@BZO95
bumping gtest to 1.12.1 (#2538)
08e21ea 
Summary:
Pull Request resolved: facebookresearch/faiss#2538

Due to google/googletest#3219 gtest doesn't compile with gcc 11 - Ubuntu 22.04 has GCC 11.2 currently.

The fix was google/googletest#3024 so I'm bumping gtest to latest.

Reviewed By: alexanderguzhva

Differential Revision: D40512746

fbshipit-source-id: 75f3c3c7f8a117af8430c2f74a7f8d164ca9877b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@derekmauro derekmauro

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Thomas-Barbier-1A @Maximuscari205 @derekmauro @suertreus