Replace the last instance of throw() with noexcept. NFC.#2773
Merged
mbxx merged 1 commit intogoogle:masterfrom Apr 16, 2020
Merged
Replace the last instance of throw() with noexcept. NFC.#2773mbxx merged 1 commit intogoogle:masterfrom
throw() with noexcept. NFC.#2773mbxx merged 1 commit intogoogle:masterfrom
Conversation
Fixes a -Wdeprecated warning.
/home/travis/build/Quuxplusone/googletest/googletest/test/googletest-death-test_ex_test.cc:62:28: error:
dynamic exception specifications are deprecated [-Werror,-Wdeprecated]
const char* what() const throw() override { return "exceptional message"; }
^~~~~~~
/home/travis/build/Quuxplusone/googletest/googletest/test/googletest-death-test_ex_test.cc:62:28: note:
use 'noexcept' instead
const char* what() const throw() override { return "exceptional message"; }
^~~~~~~
noexcept
Contributor
Author
|
@zhangxy988 gentle ping! |
Contributor
|
Sorry for the late reply. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a
-Wdeprecatedwarning.@zhangxy988 PTAL