fix: use debugValueToString for debugger operations#759
Merged
sbarzowski merged 1 commit intogoogle:masterfrom Jun 11, 2024
Merged
fix: use debugValueToString for debugger operations#759sbarzowski merged 1 commit intogoogle:masterfrom
sbarzowski merged 1 commit intogoogle:masterfrom
Conversation
The `valueToString` operation introduced by google#742 is incompatible with the way the implementation from google#739 as it tries to manifest an object from stack while the implementation needed by the debugger returns the value as-is without further evaluation.
Contributor
|
Thank you! |
vhata
pushed a commit
to discord/go-jsonnet
that referenced
this pull request
Aug 30, 2024
The `valueToString` operation introduced by google#742 is incompatible with the way the implementation from google#739 as it tries to manifest an object from stack while the implementation needed by the debugger returns the value as-is without further evaluation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
valueToStringoperation introduced by #742 is incompatible with the way the implementation from #739 as it tries to manifest an object from stack while the implementation needed by the debugger returns the value as-is without further evaluation.