Adds std.any and std.all to jsonnet-lint#695
Merged
sparkprime merged 2 commits intogoogle:masterfrom May 25, 2023
Merged
Conversation
Contributor
|
I don't think we have tests for each specific std function and I think it'd be a bit toily to do that. They really ought to be taken from a declarative config of some sort, or perhaps annotations in the code. So I'll just accept this as is. |
vhata
pushed a commit
to discord/go-jsonnet
that referenced
this pull request
Aug 30, 2024
Co-authored-by: Dave Cunningham <sparkprime@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did not add test cases. I haven't learned how the testing language works yet. Please build and test.
Fix for Issue #697