Implement std.trim for string#684
Merged
sparkprime merged 5 commits intogoogle:masterfrom Jun 13, 2023
Merged
Conversation
Contributor
Author
|
Tests added in this PR are working fine. Not sure why 2 other checks are failing. Can someone help here? |
sparkprime
reviewed
May 3, 2023
| return nil, err | ||
| } | ||
| sStr := str.getGoString() | ||
| return makeValueString(strings.TrimSpace(sStr)), nil |
Contributor
There was a problem hiding this comment.
To be compatible with C++, this should be strings.Trim with explicit " \t" I think?
Contributor
Author
There was a problem hiding this comment.
strings.TrimSpace removes all kinds of spaces '\t', '\n', '\v', '\f', '\r', ' ', U+0085 (NEL), U+00A0 (NBSP).
Contributor
|
I think the tests will work if you rebase. |
vhata
pushed a commit
to discord/go-jsonnet
that referenced
this pull request
Aug 30, 2024
* Implement std.trim for string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
std.trimfunction in standard library.PR for cpp-jsonnet: google/jsonnet#1067