Skip to content

feat: Add sorting list options for secret scanning#3481

Merged
gmlewis merged 1 commit intogoogle:masterfrom
maaarcelino:feat/secret-scanning-sort
Feb 17, 2025
Merged

feat: Add sorting list options for secret scanning#3481
gmlewis merged 1 commit intogoogle:masterfrom
maaarcelino:feat/secret-scanning-sort

Conversation

@maaarcelino
Copy link
Copy Markdown
Contributor

@maaarcelino maaarcelino commented Feb 17, 2025

Similar to #3477 this adds the missing sorting options from the SecretScanningAlertListOptions struct.

These options are available in the list-secret-scanning-alerts-for-a-repository endpoint and the respective ones for orgs and enterprises.

@maaarcelino
Copy link
Copy Markdown
Contributor Author

maaarcelino commented Feb 17, 2025 •
edited
Loading

@gmlewis After this is merged, could you cut another minor release, please? 🙏 I promise this is the last one 😄

@gmlewis
Copy link
Copy Markdown
Collaborator

gmlewis commented Feb 17, 2025 •
edited
Loading

@gmlewis After this is merged, could you cut another minor release, please? 🙏 I promise this is the last one 😄

Yes, but it will probably be closer to this evening.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.02%. Comparing base (81dc7a9) to head (da5a31a).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3481   +/-   ##
=======================================
  Coverage   91.02%   91.02%           
=======================================
  Files         179      179           
  Lines       15561    15561           
=======================================
  Hits        14165    14165           
  Misses       1223     1223           
  Partials      173      173

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gmlewis
gmlewis approved these changes Feb 17, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @maaarcelino!
LGTM.
Merging.

@gmlewis gmlewis merged commit e4c974e into google:master Feb 17, 2025
7 checks passed
@gmlewis gmlewis mentioned this pull request Feb 17, 2025
Merged
@gmlewis
Copy link
Copy Markdown
Collaborator

gmlewis commented Feb 17, 2025

@gmlewis After this is merged, could you cut another minor release, please? 🙏 I promise this is the last one 😄

This is now available here: https://github.com/google/go-github/releases/tag/v69.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewis gmlewis gmlewis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maaarcelino @gmlewis