fix: Add missing query params to AlertListOptions#3477
fix: Add missing query params to AlertListOptions#3477gmlewis merged 1 commit intogoogle:masterfrom maaarcelino:fix/list-alerts-options
Conversation
|
I ran the linting, testing and generation scripts. @gmlewis can you please take a look? 🙏 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3477 +/- ##
=======================================
Coverage 91.04% 91.04%
=======================================
Files 179 179
Lines 15551 15551
=======================================
Hits 14158 14158
Misses 1221 1221
Partials 172 172 ☔ View full report in Codecov by Sentry. |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @maaarcelino!
LGTM.
Merging.
|
@gmlewis Thanks! Any word on when I can expect a new release? Is there any chance you could do a minor release sooner than later? |
|
Usually we cut a release monthly, but we've also tried to be accommodating to requests, so I can work on a minor release. |
Done: https://github.com/google/go-github/releases/tag/v69.1.0 |
|
That's fantastic. Thank you so much @gmlewis! ❤️ |
As per the official documentation the endpoints to list alerts for both an organization and a repository accept three additional params which are not included in this SDK. Those are:
tool_guid,directionandsort.See:
This PR adds those fields and extends the tests to cover them as well.