Skip to content

fix!: Typo in field names in the PullStats struct#3445

Merged
gmlewis merged 1 commit intogoogle:masterfrom
alexandear-org:fix/typo-pullstats-fields
Jan 20, 2025
Merged

fix!: Typo in field names in the PullStats struct#3445
gmlewis merged 1 commit intogoogle:masterfrom
alexandear-org:fix/typo-pullstats-fields

Conversation

@alexandear
Copy link
Copy Markdown
Contributor

@alexandear alexandear commented Jan 20, 2025

BREAKING CHANGE: MergablePulls=>MergeablePulls, UnmergablePulls=>UnmergeablePulls

This PR corrects field typos in the github.PullStats struct:

  • MergablePulls -> MergeablePulls (because json:"mergeable_pulls")
  • UnmergablePulls -> UnmergeablePulls (because json:"unmergeable_pulls")

gmlewis
gmlewis approved these changes Jan 20, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alexandear !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@stevehipwell - do you have time for a code review?

@gmlewis gmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Jan 20, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.26%. Comparing base (eb92cca) to head (e4c5f92).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3445   +/-   ##
=======================================
  Coverage   92.26%   92.26%           
=======================================
  Files         174      174           
  Lines       15023    15023           
=======================================
  Hits        13861    13861           
  Misses       1068     1068           
  Partials       94       94

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

stevehipwell
stevehipwell approved these changes Jan 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis
Copy link
Copy Markdown
Collaborator

gmlewis commented Jan 20, 2025

Thank you, @stevehipwell!
Merging.

@alexandear alexandear changed the title fix: Typo in field names in the PullStats struct fix!: Typo in field names in the PullStats struct Jan 20, 2025
@gmlewis gmlewis merged commit b8c2253 into google:master Jan 20, 2025
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Jan 20, 2025
@gmlewis gmlewis mentioned this pull request Feb 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewis gmlewis gmlewis approved these changes

+1 more reviewer

@stevehipwell stevehipwell stevehipwell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexandear @gmlewis @stevehipwell