fix!: Remove unused Stats field from Commit struct#3395
Merged
gmlewis merged 1 commit intogoogle:masterfrom Dec 18, 2024
Merged
fix!: Remove unused Stats field from Commit struct#3395gmlewis merged 1 commit intogoogle:masterfrom
Stats field from Commit struct#3395gmlewis merged 1 commit intogoogle:masterfrom
Conversation
This field appears to never be populated throughout the codebase. Closes google#3394
Stats field from Commit structStats field from Commit struct
gmlewis
approved these changes
Dec 18, 2024
Collaborator
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @acouvreur !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3395 +/- ##
==========================================
- Coverage 97.72% 92.21% -5.51%
==========================================
Files 153 173 +20
Lines 13390 14770 +1380
==========================================
+ Hits 13085 13620 +535
- Misses 215 1060 +845
Partials 90 90 ☔ View full report in Codecov by Sentry. |
DiegoDev2
approved these changes
Dec 18, 2024
Contributor
DiegoDev2
left a comment
There was a problem hiding this comment.
Reviewing the issue this definitely deserves a merge. Good job @acouvreur
Collaborator
|
Thank you, @DiegoDev2 ! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The unused
Statsfield is removed from theCommitstruct.This field appears to never be populated throughout the codebase.
Closes #3394