Add support DeploymentReview Event, ReviewCustomDeploymentProtectionRule API, GetPendingDeployments API#3254
Conversation
6343133 to
428d19d
Compare
428d19d to
33c2e61
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3254 +/- ##
==========================================
- Coverage 97.72% 92.95% -4.77%
==========================================
Files 153 171 +18
Lines 13390 11680 -1710
==========================================
- Hits 13085 10857 -2228
- Misses 215 729 +514
- Partials 90 94 +4 ☔ View full report in Codecov by Sentry. |
|
Hello, @gmlewis.
I know this repository is supported by volunteers, but I want to release this. |
Do you have a coworker you could ask to perform the code review? |
Probably not. |
We welcome new contributors to this repo all the time. All new Go developers are welcome to contribute with PRs or code reviews. See CONTRIBUTING.md for more information. |
|
Oh, I mean that a user who has never committed to the default branch (i.e., a user who is not listed as a "contributor") may not be able to assign itself as a reviewer on github because I have tried other PR but I couldn't. |
|
I've asked @srgustafson8 if a code review might be possible since @srgustafson8 is actively working on other PRs right now... |
Just FYI - it is almost never necessary that a reviewer be assigned in this repo on any particular PR. |
|
In fact, @air-hand - please feel free to perform code reviews yourself on any open PRs that have the "Needs Review" label... all contributions are greatly appreciated! |
Thanks @gmlewis, I finally understand. (I had always assign reviewer myself on PR before code review...) |
Yes, that is totally reasonable and quite common especially in a corporate environment. |
|
Thank you, @srgustafson8 ! |
Fixes #3252
Deployment Review Event: https://docs.github.com/en/enterprise-cloud@latest/webhooks/webhook-events-and-payloads?actionType=requested#deployment_review
Review Custom Deployment Protection Rule: https://docs.github.com/en/enterprise-cloud@latest/rest/actions/workflow-runs?apiVersion=2022-11-28#review-custom-deployment-protection-rules-for-a-workflow-run
The following APIs were also not yet implemented and are now supported.
Get pending deployments: https://docs.github.com/en/enterprise-cloud@latest/rest/actions/workflow-runs?apiVersion=2022-11-28#get-pending-deployments-for-a-workflow-run