Add CommitID, InReplyTo, and SubjectType to DraftReviewComment#3169
Merged
gmlewis merged 1 commit intogoogle:masterfrom May 14, 2024
Merged
Add CommitID, InReplyTo, and SubjectType to DraftReviewComment#3169gmlewis merged 1 commit intogoogle:masterfrom
gmlewis merged 1 commit intogoogle:masterfrom
Conversation
gmlewis
reviewed
May 14, 2024
| Position *int `json:"position,omitempty"` | ||
| Body *string `json:"body,omitempty"` | ||
| CommitID *string `json:"commit_id,omitempty"` | ||
| InReplyTo *int64 `json:"in_reply_to,omitempty"` |
Collaborator
There was a problem hiding this comment.
On this page: https://docs.github.com/en/rest/pulls/reviews?apiVersion=2022-11-28#list-comments-for-a-pull-request-review--code-samples
I see in_reply_to_id but I'm not finding id_reply_to anywhere on the page.
Where are you finding that field?
Also, I'm not finding subject_type anywhere on that page. Where is that field coming from?
Collaborator
There was a problem hiding this comment.
Oh, I see them now on this page :https://docs.github.com/en/rest/pulls/comments?apiVersion=2022-11-28#create-a-review-comment-for-a-pull-request
Sorry for the confusion.
gmlewis
approved these changes
May 14, 2024
Collaborator
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @matt-simons !
LGTM.
Merging.
haya14busa
added a commit
to reviewdog/reviewdog
that referenced
this pull request
Jul 1, 2024
haya14busa
added a commit
to reviewdog/reviewdog
that referenced
this pull request
Jul 2, 2024
matt-simons
added a commit
to matt-simons/go-github
that referenced
this pull request
Jul 24, 2024
google#3169)" This reverts commit 06c9709.
This was referenced Jul 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3168
Made InReplyTo an int64 following the established type in https://pkg.go.dev/github.com/google/go-github/v62/github#PullRequestComment but happy to change if that or anything else is incorrect.