Skip to content

Add missing CodeScanning endpoints#2900

Merged
gmlewis merged 4 commits intogoogle:masterfrom
jporzucek:master
Aug 30, 2023
Merged

Add missing CodeScanning endpoints#2900
gmlewis merged 4 commits intogoogle:masterfrom
jporzucek:master

Conversation

@jporzucek
Copy link
Copy Markdown
Contributor

@jporzucek jporzucek commented Aug 26, 2023

Fixes #2899

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 26, 2023 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.11%. Comparing base (38ca69f) to head (81acba8).
⚠️ Report is 493 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2900      +/-   ##
==========================================
+ Coverage   98.10%   98.11%   +0.01%     
==========================================
  Files         142      142              
  Lines       12340    12415      +75     
==========================================
+ Hits        12106    12181      +75     
  Misses        159      159              
  Partials       75       75

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gmlewis
gmlewis requested changes Aug 26, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jporzucek .
Just a few changes to make, please, mostly relating to capitalizations, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Aug 26, 2023
@jporzucek
Copy link
Copy Markdown
Contributor Author

jporzucek commented Aug 28, 2023 •
edited
Loading

@ganeshkumarsv @nightlark @AbbanMustafa Since you've been working on this file, kindly ask for an approval 🙏

gmlewis
gmlewis approved these changes Aug 28, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jporzucek !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Aug 30, 2023
@gmlewis
Copy link
Copy Markdown
Collaborator

gmlewis commented Aug 30, 2023

Thank you, @WillAbides !
Merging.

@gmlewis gmlewis merged commit e3cda78 into google:master Aug 30, 2023
@gmlewis gmlewis mentioned this pull request Sep 5, 2023
Merged
gmlewis pushed a commit to gmlewis/go-github that referenced this pull request Sep 19, 2023
@jporzucek @gmlewis
Add missing CodeScanning endpoints (google#2900)
6ea29e6 
Fixes: google#2899.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewis gmlewis gmlewis approved these changes

+1 more reviewer

@WillAbides WillAbides WillAbides approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing CodeScanning endpoints

3 participants

@jporzucek @gmlewis @WillAbides