Skip to content

Add SubmoduleGitURL to RepositoryContent#2880

Merged
gmlewis merged 1 commit intogoogle:masterfrom
gmlewis:chore/i2877-add-submodule-git-url
Aug 16, 2023
Merged

Add SubmoduleGitURL to RepositoryContent#2880
gmlewis merged 1 commit intogoogle:masterfrom
gmlewis:chore/i2877-add-submodule-git-url

Conversation

@gmlewis
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis commented Aug 16, 2023

Fixes: #2877.

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Aug 16, 2023
@gmlewis
Copy link
Copy Markdown
Collaborator Author

gmlewis commented Aug 16, 2023

@Parker77 - do you have time for another review, please?

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 16, 2023

Codecov Report

Merging #2880 (641ad3e) into master (0c562f6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2880   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files         140      140           
  Lines       12269    12269           
=======================================
  Hits        12031    12031           
  Misses        162      162           
  Partials       76       76           
Files Changed Coverage Δ
github/repos_contents.go 87.82% <ø> (ø)

Copy link
Copy Markdown

@Parker77 Parker77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Aug 16, 2023
@gmlewis
Copy link
Copy Markdown
Collaborator Author

gmlewis commented Aug 16, 2023

Thank you, @Parker77 !
Merging.

@gmlewis gmlewis merged commit e94b955 into google:master Aug 16, 2023
@gmlewis gmlewis deleted the chore/i2877-add-submodule-git-url branch August 16, 2023 17:53
gmlewis added a commit to gmlewis/go-github that referenced this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhancing RepositoryContent Struct for SubmoduleGitURL support in github/repos_contents.go

2 participants