Adding missing field important to find branch in fork from same owner#2873
Adding missing field important to find branch in fork from same owner#2873gmlewis merged 6 commits intogoogle:masterfrom
Conversation
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @r-aramizu !
Please run go generate ./... in the top of the repo and then push (not force-push) the changes to this same PR, and that should fix the tests.
See CONTRIBUTING.md for more information.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Thank you @gmlewis ! My bad for forget this 😅 |
|
@r-aramizu - please follow the CLA instructions from the comment above: |
Codecov Report
@@ Coverage Diff @@
## master #2873 +/- ##
=======================================
Coverage 98.07% 98.07%
=======================================
Files 139 139
Lines 12357 12357
=======================================
Hits 12119 12119
Misses 162 162
Partials 76 76
|
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @r-aramizu !
LGTM.
Merging.
|
Thank you @gmlewis to review it and help me with this! 🚀 |
Hello there! I opened an issue to explain this suggestion.
I put the new field on your tests and keep working as before! There was a change that could solve my problem!
Fixes: #2872.