Fix SecretScanning API by switching arguments from url to json#2871
Fix SecretScanning API by switching arguments from url to json#2871jentfoo wants to merge 3 commits intogoogle:masterfrom
Conversation
These structs were incorrectly defined with `url` parameters, instead these need to be encoded into `json` for the request.
|
Please run |
|
Thank you! Feedback applied @gmlewis, let me know if there is anything further I can help with. |
|
It looks like you will also need to update the unit tests by changing some of the strings to Please run "go test ./..." locally to make sure all tests pass before pushing your next commit. Thanks. |
|
@jentfoo - we'll leave this PR open for a week or two, but if we haven't heard back from you, we'll close it as abandoned. |
|
@gmlewis This is a bug that should be addressed, however I don't have time to complete the requested test changes |
|
OK, thank you for the update, @jentfoo - I'll take a look when I get a chance. |
|
Hmmm... I'm looking at: So let's back up a moment. When you say "This is a bug that should be addressed"... could you please elaborate on the actual bug you are seeing? What endpoint(s) are you calling? Unless I can better understand what the actual problem is, I'm going to have to close this PR as not having enough information to fix. |
This PR was opened a while ago and I ultimately ended up switching to GraphQL for most of my needs. So I don't fully recall why I was suggesting updating However I recall an API error when the current I apologize for not being able to help further right now, but I will try to answer questions as I am able. |
|
Ah, yes! I see the problem now! Thank you, @jentfoo ! |
|
Note that this PR is being replaced by #2934 since I was unable to edit the contents of this PR myself. |
These structs were incorrectly defined with
urlparameters, instead these need to be encoded intojsonfor the request.