Skip to content

Add support for fetching SBOMs#2869

Merged
gmlewis merged 17 commits intogoogle:masterfrom
vandanrohatgi:get-sbom
Aug 16, 2023
Merged

Add support for fetching SBOMs#2869
gmlewis merged 17 commits intogoogle:masterfrom
vandanrohatgi:get-sbom

Conversation

@vandanrohatgi
Copy link
Copy Markdown
Contributor

@vandanrohatgi vandanrohatgi commented Aug 14, 2023 •
edited
Loading

Closes #2864

Adds support for fetching Software Bill of materials (SBOM) for a repository.

  • go generate
  • go test
  • go vet

gmlewis
gmlewis requested changes Aug 14, 2023
View reviewed changes
vandanrohatgi and others added 12 commits August 14, 2023 19:09
@vandanrohatgi
Add support for fetching sboms
57e5ce1
@vandanrohatgi @gmlewis
Update github/dependency_graph.go
1157290 
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@vandanrohatgi @gmlewis
Update github/dependency_graph.go
4d1aff4 
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@vandanrohatgi @gmlewis
Update github/dependency_graph.go
06ddb1c 
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@vandanrohatgi @gmlewis
Update github/dependency_graph.go
5e93a14 
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@vandanrohatgi @gmlewis
Update github/dependency_graph.go
f9225cd 
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@vandanrohatgi @gmlewis
Update github/dependency_graph.go
a294cff 
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@vandanrohatgi @gmlewis
Update github/dependency_graph.go
ee3ea27 
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@vandanrohatgi @gmlewis
Apply suggestions from code review
f7e6243 
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@vandanrohatgi
Merge branch 'get-sbom' of github.com:vandanrohatgi/go-github into ge…
9f3a92c 
…t-sbom
@vandanrohatgi
Fix PR reviews
7c083bd
@vandanrohatgi
Merge branch 'master' into get-sbom
7857903
@vandanrohatgi vandanrohatgi requested a review from gmlewis August 15, 2023 05:11
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 15, 2023 •
edited
Loading

Codecov Report

Merging #2869 (c48702b) into master (3ecf12c) will decrease coverage by 0.02%.
Report is 8 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2869      +/-   ##
==========================================
- Coverage   98.07%   98.06%   -0.02%     
==========================================
  Files         139      140       +1     
  Lines       12348    12269      -79     
==========================================
- Hits        12110    12031      -79     
  Misses        162      162              
  Partials       76       76
Files Changed Coverage Δ
github/dependency_graph.go 100.00% <100.00%> (ø)
github/github.go 97.97% <100.00%> (+<0.01%) ⬆️

... and 6 files with indirect coverage changes

gmlewis
gmlewis requested changes Aug 15, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @vandanrohatgi !
Just a couple minor comment nits, please, that I apparently missed the first time
before we await a second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Aug 15, 2023
@vandanrohatgi @gmlewis
Apply suggestions from code review
024b4a3 
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@vandanrohatgi
Copy link
Copy Markdown
Contributor Author

vandanrohatgi commented Aug 15, 2023

Thank you so much for the valuable feedback @gmlewis ! Learned a lot. Though I feel I only increased your workload rather than contributing :)

@vandanrohatgi vandanrohatgi requested a review from gmlewis August 15, 2023 13:10
@gmlewis
Copy link
Copy Markdown
Collaborator

gmlewis commented Aug 15, 2023

Thank you so much for the valuable feedback @gmlewis ! Learned a lot. Though I feel I only increased your workload rather than contributing :)

No, not at all, @vandanrohatgi ! Your contributions are appreciated more than you know!
I couldn't maintain this repo without the help of wonderful contributors like yourself.

gmlewis
gmlewis approved these changes Aug 15, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @vandanrohatgi !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis changed the title Add support for fetching sboms Add support for fetching SBOMs Aug 15, 2023
@gmlewis gmlewis mentioned this pull request Aug 16, 2023
Merged
@gmlewis
Copy link
Copy Markdown
Collaborator

gmlewis commented Aug 16, 2023

@Parker77 - do you have time for a code review, please?

Parker77
Parker77 reviewed Aug 16, 2023
View reviewed changes
@gmlewis @Parker77
Update github/dependency_graph.go
c48702b 
Co-authored-by: Parker77 <20973702+Parker77@users.noreply.github.com>
Parker77
Parker77 approved these changes Aug 16, 2023
View reviewed changes
Copy link
Copy Markdown

@Parker77 Parker77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Aug 16, 2023
@gmlewis
Copy link
Copy Markdown
Collaborator

gmlewis commented Aug 16, 2023

Thank you, @Parker77 !
Merging.

@gmlewis gmlewis merged commit 0c562f6 into google:master Aug 16, 2023
@gmlewis gmlewis mentioned this pull request Aug 16, 2023
Merged
@vandanrohatgi vandanrohatgi mentioned this pull request Aug 19, 2023
Merged
3 tasks
gmlewis pushed a commit to gmlewis/go-github that referenced this pull request Sep 19, 2023
@vandanrohatgi @gmlewis
Add support for fetching SBOMs (google#2869)
7f48e67 
Fixes: google#2864.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewis gmlewis gmlewis approved these changes

+1 more reviewer

@Parker77 Parker77 Parker77 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature Request: Repository SBOM generation

3 participants

@vandanrohatgi @gmlewis @Parker77