Add OldLogin field to AuditEntryData#2850
Merged
gmlewis merged 3 commits intogoogle:masterfrom Jul 28, 2023
lmartinking:patch-3
Merged
Add OldLogin field to AuditEntryData#2850gmlewis merged 3 commits intogoogle:masterfrom lmartinking:patch-3
OldLogin field to AuditEntryData#2850gmlewis merged 3 commits intogoogle:masterfrom
lmartinking:patch-3
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2850 +/- ##
=======================================
Coverage 98.06% 98.06%
=======================================
Files 138 138
Lines 12318 12318
=======================================
Hits 12080 12080
Misses 162 162
Partials 76 76
|
gmlewis
approved these changes
Jul 28, 2023
Collaborator
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @lmartinking !
LGTM.
Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When renaming a Github organisation, the audit log entry (with action
org.rename) will containdata.old_loginwhich provides the prior name of the organisation.This PR builds upon prior work which added support for the
datafield within an Audit Log entry.