Add GetAutomatedSecurityFixes to report status#2842
Merged
gmlewis merged 2 commits intogoogle:masterfrom Aug 15, 2023
Merged
Conversation
gmlewis
reviewed
Jul 25, 2023
Codecov Report
@@ Coverage Diff @@
## master #2842 +/- ##
=======================================
Coverage 98.06% 98.07%
=======================================
Files 138 139 +1
Lines 12314 12357 +43
=======================================
+ Hits 12076 12119 +43
Misses 162 162
Partials 76 76
|
gmlewis
reviewed
Jul 25, 2023
gmlewis
approved these changes
Jul 26, 2023
Collaborator
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @grahamhar !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
gmlewis
approved these changes
Jul 26, 2023
github/repos.go
Outdated
| return nil, nil, err | ||
| } | ||
|
|
||
| // TODO: remove custom Accept header when this API fully launches |
Contributor
There was a problem hiding this comment.
Looks like API docs now recommend using the common application/vnd.github+json header. Maybe we can remove this custom header?
Contributor
Author
There was a problem hiding this comment.
Happy to do that as part of this PR.
Contributor
Author
There was a problem hiding this comment.
I've made the changes I think are needed please let me know if I need to do anything else.
Collaborator
|
Thank you, @vandanrohatgi ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #2080. It is also required by upstream projects such as terraform-provider-github, see issue 1301