Adding delete_branch_on_merge support for repos#1388
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
4c9f9aa to
059229a
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
059229a to
2a1aea9
Compare
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @stefansedich, but this won't work yet as written. Please address the comment below.
Otherwise, LGTM.
After you make the requested change and we get a second LGTM, we can merge.
| AllowSquashMerge *bool `json:"allow_squash_merge,omitempty"` | ||
| AllowMergeCommit *bool `json:"allow_merge_commit,omitempty"` | ||
| AllowRebaseMerge *bool `json:"allow_rebase_merge,omitempty"` | ||
| DeleteBranchOnMerge *bool `json:"delete_branch_on_merge,omitempty"` |
There was a problem hiding this comment.
Please copy this new field's value after line 347 below, otherwise it has no effect.
There was a problem hiding this comment.
My bad 😞 my grep had failed me finding the places the other fields were set I assumed it was some magic but missed this obvious place! Should be fixed.
There was a problem hiding this comment.
No problem! That's why we do code reviews! 😄
That's nothing compared to some of the things I've done. 😄
Thank you for fixing it!
2a1aea9 to
98e73fa
Compare
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @stefansedich!
LGTM.
Awaiting second LGTM before merging.
|
Thank you, @wesleimp! |
Since [this commit](google/go-github#1388) it is possible to manage if the project should close branches automatically after a PR is merged. The current version on this project already supports this new config. This commit introduces the new option, using the same default as the GitHub API uses. Fix https://github.com/terraform-providers/terraform-provider-github/issues/264
Since [this commit](google/go-github#1388) it is possible to manage if the project should close branches automatically after a PR is merged. The current version on this project already supports this new config. This commit introduces the new option, using the same default as the GitHub API uses. Fix https://github.com/terraform-providers/terraform-provider-github/issues/264
Adding support for the new delete_branch_on_merge setting for repositories.
"Finally" Closes #1245